chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/password_manager/password_generation_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index 0a0ad290129e55cde05a0ae29147c6e3067c48d7..be27fc3ebc3b70bc1ae7be15ab98ab5dad2009cc 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -203,7 +203,7 @@ TEST_F(ChromePasswordManagerClientTest,

TEST_F(ChromePasswordManagerClientTest,

IsAutomaticPasswordSavingEnabledWhenFlagIsSetTest) {

- CommandLine::ForCurrentProcess()->AppendSwitch(

+ base::CommandLine::ForCurrentProcess()->AppendSwitch(

password_manager::switches::kEnableAutomaticPasswordSaving);

if (chrome::VersionInfo::GetChannel() == chrome::VersionInfo::CHANNEL_UNKNOWN)

EXPECT_TRUE(GetClient()->IsAutomaticPasswordSavingEnabled());

@@ -238,7 +238,7 @@ TEST_F(ChromePasswordManagerClientTest, ShouldAskUserToSubmitURLEmptyURL) {

TEST_F(ChromePasswordManagerClientTest, ShouldFilterAutofillResult_Reauth) {

// Make client disallow only reauth requests.

- CommandLine* command_line = CommandLine::ForCurrentProcess();

+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

command_line->AppendSwitch(

password_manager::switches::kDisallowAutofillSyncCredentialForReauth);

scoped_ptr<TestChromePasswordManagerClient> client(

@@ -278,7 +278,7 @@ TEST_F(ChromePasswordManagerClientTest, ShouldFilterAutofillResult) {

EXPECT_FALSE(client->ShouldFilterAutofillResult(form));

// Adding disallow switch should cause sync credential to be filtered.

- CommandLine* command_line = CommandLine::ForCurrentProcess();

+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

command_line->AppendSwitch(

password_manager::switches::kDisallowAutofillSyncCredential);

client.reset(new TestChromePasswordManagerClient(web_contents()));