chrome/browser/safe_browsing/safe_browsing_service.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc

index 88750c18b8d72bc6a0a6dada878eaf7391e3b161..e5c8fd53a6b0128b659f8a5332285acfe30f363f 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc

@@ -219,7 +219,7 @@ void SafeBrowsingService::Initialize() {

#if defined(FULL_SAFE_BROWSING)

#if !defined(OS_ANDROID)

- if (!CommandLine::ForCurrentProcess()->HasSwitch(

+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableClientSidePhishingDetection)) {

csd_service_.reset(safe_browsing::ClientSideDetectionService::Create(

url_request_context_getter_.get()));

@@ -443,7 +443,7 @@ SafeBrowsingProtocolConfig SafeBrowsingService::GetProtocolConfig() const {

#endif

#endif // defined(OS_WIN)

- CommandLine* cmdline = CommandLine::ForCurrentProcess();

+ base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();

config.disable_auto_update =

cmdline->HasSwitch(switches::kSbDisableAutoUpdate) ||

cmdline->HasSwitch(switches::kDisableBackgroundNetworking);