Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: chrome/browser/translate/translate_service.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_service.h" 5 #include "chrome/browser/translate/translate_service.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 language_list->SetResourceRequestsAllowed( 89 language_list->SetResourceRequestsAllowed(
90 resource_request_allowed_notifier_.ResourceRequestsAllowed()); 90 resource_request_allowed_notifier_.ResourceRequestsAllowed());
91 } 91 }
92 92
93 // static 93 // static
94 bool TranslateService::IsTranslateBubbleEnabled() { 94 bool TranslateService::IsTranslateBubbleEnabled() {
95 #if defined(USE_AURA) 95 #if defined(USE_AURA)
96 return true; 96 return true;
97 #elif defined(OS_MACOSX) 97 #elif defined(OS_MACOSX)
98 // The bubble UX is experimental on Mac OS X. 98 // The bubble UX is experimental on Mac OS X.
99 return CommandLine::ForCurrentProcess()->HasSwitch( 99 return base::CommandLine::ForCurrentProcess()->HasSwitch(
100 switches::kEnableTranslateNewUX); 100 switches::kEnableTranslateNewUX);
101 #else 101 #else
102 // The bubble UX is not implemented on other platforms. 102 // The bubble UX is not implemented on other platforms.
103 return false; 103 return false;
104 #endif 104 #endif
105 } 105 }
106 106
107 // static 107 // static
108 std::string TranslateService::GetTargetLanguage(PrefService* prefs) { 108 std::string TranslateService::GetTargetLanguage(PrefService* prefs) {
109 std::vector<std::string> accept_languages_list; 109 std::vector<std::string> accept_languages_list;
(...skipping 12 matching lines...) Expand all
122 // - an FTP page (as FTP pages tend to have long lists of filenames that may 122 // - an FTP page (as FTP pages tend to have long lists of filenames that may
123 // confuse the CLD) 123 // confuse the CLD)
124 return !url.is_empty() && !url.SchemeIs(content::kChromeUIScheme) && 124 return !url.is_empty() && !url.SchemeIs(content::kChromeUIScheme) &&
125 !url.SchemeIs(content::kChromeDevToolsScheme) && 125 !url.SchemeIs(content::kChromeDevToolsScheme) &&
126 #if defined(OS_CHROMEOS) 126 #if defined(OS_CHROMEOS)
127 !(url.SchemeIs(extensions::kExtensionScheme) && 127 !(url.SchemeIs(extensions::kExtensionScheme) &&
128 url.DomainIs(file_manager::kFileManagerAppId)) && 128 url.DomainIs(file_manager::kFileManagerAppId)) &&
129 #endif 129 #endif
130 !url.SchemeIs(url::kFtpScheme); 130 !url.SchemeIs(url::kFtpScheme);
131 } 131 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_browsertest.cc ('k') | chrome/browser/ui/app_list/app_list_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698