Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.

Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).

For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.

BUG=433486
Committed: https://crrev.com/1dbe123c5e7b2d41e517049c1b98d8ad75563b98
Cr-Commit-Position: refs/heads/master@{#310162}

[Evan Stade, 2014-12-19 01:40:37]

estade@chromium.org changed reviewers:
+ avi@chromium.org, cpalmer@chromium.org, dbeam@chromium.org

[Evan Stade, 2014-12-19 01:40:37]

+avi for content
+cpalmer for ipc
+dbeam for all else

[Dan Beam, 2014-12-19 01:59:34]

https://codereview.chromium.org/796493004/diff/40001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(right):

https://codereview.chromium.org/796493004/diff/40001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:476:
InitializeDOMMessageQueue();
nit: InitializeDomMessageQueue() (I'm pretty sure DOMMessageQueue should be
DomMessageQueue but was written before we started using HttpUrl instead of
HTTPURL)

https://codereview.chromium.org/796493004/diff/40001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:1779: 
nit: ^H

https://codereview.chromium.org/796493004/diff/40001/chrome/renderer/autofill...
File chrome/renderer/autofill/autofill_renderer_browsertest.cc (left):

https://codereview.chromium.org/796493004/diff/40001/chrome/renderer/autofill...
chrome/renderer/autofill/autofill_renderer_browsertest.cc:376:
TEST_F(RequestAutocompleteRendererTest, SubframeNavigateCancels) {
where are the equivalent tests to ensure an <iframe> that invokes rAc hides the
dialog if it's navigated?

[Avi (use Gerrit), 2014-12-19 04:44:18]

content lgtm

[Evan Stade, 2014-12-19 21:21:12]

https://codereview.chromium.org/796493004/diff/40001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(right):

https://codereview.chromium.org/796493004/diff/40001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:1779: 
On 2014/12/19 01:59:34, Dan Beam wrote:
> nit: ^H

Done.

https://codereview.chromium.org/796493004/diff/40001/chrome/renderer/autofill...
File chrome/renderer/autofill/autofill_renderer_browsertest.cc (left):

https://codereview.chromium.org/796493004/diff/40001/chrome/renderer/autofill...
chrome/renderer/autofill/autofill_renderer_browsertest.cc:376:
TEST_F(RequestAutocompleteRendererTest, SubframeNavigateCancels) {
On 2014/12/19 01:59:34, Dan Beam wrote:
> where are the equivalent tests to ensure an <iframe> that invokes rAc hides
the
> dialog if it's navigated?

added. I don't know how it worked before, but I had to add a little code to
ChromeAutofillClient to get it to keep working.

[Evan Stade, 2014-12-20 00:26:39]

estade@chromium.org changed reviewers:
+ sgurun@chromium.org

[Evan Stade, 2014-12-20 00:26:40]

+sgurun for AW

[sgurun-gerrit only, 2014-12-20 00:59:44]

On 2014/12/20 00:26:40, Evan Stade wrote:
> +sgurun for AW

aw lgtm

[Dan Beam, 2014-12-20 01:10:51]

https://codereview.chromium.org/796493004/diff/60001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
(right):

https://codereview.chromium.org/796493004/diff/60001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:1840:
std::string unused;
lame
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...

https://codereview.chromium.org/796493004/diff/60001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/chrome_autofill_client.cc (right):

https://codereview.chromium.org/796493004/diff/60001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/chrome_autofill_client.cc:229:
HideRequestAutocompleteDialog();
nit: create a HideIfLastRfhToRac(render_frame_host) and call from both places

https://codereview.chromium.org/796493004/diff/60001/components/autofill/cont...
File components/autofill/content/renderer/autofill_agent.cc (left):

https://codereview.chromium.org/796493004/diff/60001/components/autofill/cont...
components/autofill/content/renderer/autofill_agent.cc:255: Send(new
AutofillHostMsg_CancelRequestAutocomplete(routing_id()));
this is how it used to work

https://codereview.chromium.org/796493004/diff/100001/components/autofill/con...
File components/autofill/content/renderer/autofill_agent.cc (left):

https://codereview.chromium.org/796493004/diff/100001/components/autofill/con...
components/autofill/content/renderer/autofill_agent.cc:194: form_cache_.Reset();
does this still need to happen somehow?

[Dan Beam, 2014-12-20 01:13:27]

lgtm

https://codereview.chromium.org/796493004/diff/100001/components/autofill/con...
File components/autofill/content/renderer/autofill_agent.cc (left):

https://codereview.chromium.org/796493004/diff/100001/components/autofill/con...
components/autofill/content/renderer/autofill_agent.cc:194: form_cache_.Reset();
On 2014/12/20 01:10:51, Dan Beam wrote:
> does this still need to happen somehow?

whoops, from CL desc:
"""AutofillAgent::FrameDetached is no longer necessary because form_cache_ only
holds the forms for a single frame."""

[Evan Stade, 2014-12-23 06:17:48]

estade@chromium.org changed reviewers:
+ jschuh@chromium.org

[Evan Stade, 2014-12-23 06:17:49]

ping cpalmer for ipc
+jschuh in case cpalmer is ooo

[jschuh, 2015-01-05 16:55:05]

jschuh was out too. :(

delayed lgtm for ipc security. notes: field and message removal

[Evan Stade, 2015-01-05 18:11:05]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-05 18:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796493004/100001

[commit-bot: I haz the power, 2015-01-05 18:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 18:18:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2015-01-05 19:26:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-05 19:28:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796493004/120001

[Evan Stade, 2015-01-05 19:37:39]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-05 19:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796493004/160001

[commit-bot: I haz the power, 2015-01-05 19:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 19:53:40]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-06 22:26:18]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-06 22:26:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796493004/180001

[commit-bot: I haz the power, 2015-01-06 22:45:32]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-01-06 22:46:34]

Patchset 10 (id:??) landed as
https://crrev.com/1dbe123c5e7b2d41e517049c1b98d8ad75563b98
Cr-Commit-Position: refs/heads/master@{#310162}