components/autofill/content/renderer/password_autofill_agent.cc - Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix init order Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.h ('k') | components/autofill/core/browser/autofill_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 364d936d25c3a531d82cdd44353da80904d66c59..34068a0ee9cd1270787722b2ab8fad12ab75f0e1 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -987,9 +987,8 @@ void PasswordAutofillAgent::DidStopLoading() {

did_stop_loading_ = true;

}

-void PasswordAutofillAgent::FrameDetached(blink::WebFrame* frame) {

- if (frame == render_frame()->GetWebFrame())

- FrameClosing();

+void PasswordAutofillAgent::FrameDetached() {

+ FrameClosing();

}

void PasswordAutofillAgent::WillSendSubmitEvent(

@@ -1379,9 +1378,4 @@ void PasswordAutofillAgent::LegacyPasswordAutofillAgent::

agent_->LegacyDidStartProvisionalLoad(navigated_frame);

}

-void PasswordAutofillAgent::LegacyPasswordAutofillAgent::FrameDetached(

- blink::WebFrame* frame) {

- agent_->FrameDetached(frame);

} // namespace autofill