Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

chrome/renderer/autofill/autofill_renderer_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "chrome/test/base/ui_test_utils.h"
@@ skipping 348 matching lines @@
 
  protected:
   WebFormElement invoking_form_;
   WebLocalFrame* invoking_frame_;
   WebFrame* sibling_frame_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RequestAutocompleteRendererTest);
 };
 
-TEST_F(RequestAutocompleteRendererTest, SiblingNavigateIgnored) {
-  // Pretend that a sibling frame navigated. No cancel should be sent.
-  NavigateFrame(sibling_frame());
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_CancelRequestAutocomplete::ID));
-}
-
-TEST_F(RequestAutocompleteRendererTest, SubframeNavigateCancels) {

[Dan Beam, 2014/12/19 01:59:34]

where are the equivalent tests to ensure an <iframe> that invokes rAc hides the
dialog if it's navigated?

[Evan Stade, 2014/12/19 21:21:12]

added. I don't know how it worked before, but I had to add a little code to
ChromeAutofillClient to get it to keep working.

-  // Pretend that the invoking frame navigated. A cancel should be sent.
-  NavigateFrame(invoking_frame());
-  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_CancelRequestAutocomplete::ID));
-}
-
-TEST_F(RequestAutocompleteRendererTest, MainFrameNavigateCancels) {
-  // Pretend that the top-level frame navigated. A cancel should be sent.
-  NavigateFrame(GetMainFrame());
-  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_CancelRequestAutocomplete::ID));
-}
-
-TEST_F(RequestAutocompleteRendererTest, NoCancelOnSubframeNavigateAfterDone) {
-  // Pretend that the dialog was cancelled.
-  SimulateRequestAutocompleteResult(
-      invoking_frame_, WebFormElement::AutocompleteResultErrorCancel,
-      base::ASCIIToUTF16("Print me to the console"));
-
-  // Additional navigations should not crash nor send cancels.
-  NavigateFrame(invoking_frame());
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_CancelRequestAutocomplete::ID));
-}
-
-TEST_F(RequestAutocompleteRendererTest, NoCancelOnMainFrameNavigateAfterDone) {
-  // Pretend that the dialog was cancelled.
-  SimulateRequestAutocompleteResult(
-      invoking_frame_, WebFormElement::AutocompleteResultErrorCancel,
-      base::ASCIIToUTF16("Print me to the console"));
-
-  // Additional navigations should not crash nor send cancels.
-  NavigateFrame(GetMainFrame());
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_CancelRequestAutocomplete::ID));
-}
-
 TEST_F(RequestAutocompleteRendererTest, InvokingTwiceOnlyShowsOnce) {
   // Attempting to show the requestAutocomplete dialog again should be ignored.
   invoking_frame_->autofillClient()->didRequestAutocomplete(invoking_form());
   EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_RequestAutocomplete::ID));
 }
 
 }  // namespace autofill