components/autofill/content/renderer/password_autofill_agent.h - Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix init order Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 0326803e4d97016c7dcda49a6037e0788b10c112..e3bba5ee05c11d0053ccbfdf65267b9a09cc33b5 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -147,7 +147,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

void DidStartLoading() override;

void DidStopLoading() override;

void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;

- void FrameDetached(blink::WebFrame* frame) override;

private:

PasswordAutofillAgent* agent_;

@@ -160,6 +159,7 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

bool OnMessageReceived(const IPC::Message& message) override;

void DidFinishDocumentLoad() override;

void DidFinishLoad() override;

+ void FrameDetached() override;

void FrameWillClose() override;

void DidCommitProvisionalLoad(bool is_new_navigation) override;

void WillSendSubmitEvent(const blink::WebFormElement& form) override;

@@ -169,7 +169,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

void DidStartLoading();

void DidStopLoading();

void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame);

- void FrameDetached(blink::WebFrame* frame);

// RenderView IPC handlers:

void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);