Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix init order Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 85dd8243a5776b90905bc6ceb6a26f50b91c45c7..6afbd4ca8dd79d0d60c860e2d41e584424cf114d 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -187,13 +187,6 @@ void AutofillAgent::DidFinishDocumentLoad() {
ProcessForms();
}
-void AutofillAgent::FrameDetached(WebFrame* frame) {
- if (frame != render_frame()->GetWebFrame())
- return;
-
- form_cache_.Reset();
-}
-
void AutofillAgent::WillSubmitForm(const WebFormElement& form) {
FormData form_data;
if (WebFormElementToFormData(form,
@@ -245,19 +238,6 @@ void AutofillAgent::Resized() {
HidePopup();
}
-void AutofillAgent::LegacyFrameWillClose(blink::WebFrame* frame) {
- if (in_flight_request_form_.isNull())
- return;
-
- for (blink::WebFrame* temp = render_frame()->GetWebFrame(); temp;
- temp = temp->parent()) {
- if (temp == frame) {
- Send(new AutofillHostMsg_CancelRequestAutocomplete(routing_id()));
- break;
- }
- }
-}
-
void AutofillAgent::didRequestAutocomplete(
const WebFormElement& form) {
DCHECK_EQ(form.document().frame(), render_frame()->GetWebFrame());
@@ -274,7 +254,6 @@ void AutofillAgent::didRequestAutocomplete(
!net::IsCertStatusError(ssl_status.cert_status);
bool allow_unsafe = base::CommandLine::ForCurrentProcess()->HasSwitch(
::switches::kReduceSecurityForTesting);
-
FormData form_data;
std::string error_message;
if (!in_flight_request_form_.isNull()) {
@@ -310,7 +289,7 @@ void AutofillAgent::didRequestAutocomplete(
HidePopup();
in_flight_request_form_ = form;
- Send(new AutofillHostMsg_RequestAutocomplete(routing_id(), form_data, url));
+ Send(new AutofillHostMsg_RequestAutocomplete(routing_id(), form_data));
}
void AutofillAgent::setIgnoreTextChanges(bool ignore) {
@@ -801,10 +780,6 @@ void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
// No-op. Don't delete |this|.
}
-void AutofillAgent::LegacyAutofillAgent::FrameDetached(WebFrame* frame) {
- agent_->FrameDetached(frame);
-}
-
void AutofillAgent::LegacyAutofillAgent::FocusedNodeChanged(
const WebNode& node) {
agent_->FocusedNodeChanged(node);
@@ -814,9 +789,4 @@ void AutofillAgent::LegacyAutofillAgent::Resized() {
agent_->Resized();
}
-void AutofillAgent::LegacyAutofillAgent::FrameWillClose(
- blink::WebFrame* frame) {
- agent_->LegacyFrameWillClose(frame);
-}
-
} // namespace autofill
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698