Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix init order Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 6a3679a9ae2968b39d9c8a7cfccb1e304fa655bf..ea90fd99d597a2c18fbbe2dab589b45b3cd27fca 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -66,10 +66,8 @@ class AutofillAgent : public content::RenderFrameObserver,
private:
// content::RenderViewObserver:
void OnDestruct() override;
- void FrameDetached(blink::WebFrame* frame) override;
void FocusedNodeChanged(const blink::WebNode& node) override;
void Resized() override;
- void FrameWillClose(blink::WebFrame* frame) override;
AutofillAgent* agent_;
@@ -119,10 +117,8 @@ class AutofillAgent : public content::RenderFrameObserver,
// Pass-throughs from LegacyAutofillAgent. These correlate with
// RenderViewObserver methods.
- void FrameDetached(blink::WebFrame* frame);
void FocusedNodeChanged(const blink::WebNode& node);
void Resized();
- void LegacyFrameWillClose(blink::WebFrame* frame);
// PageClickListener:
void FormControlElementClicked(const blink::WebFormControlElement& element,
@@ -217,7 +213,7 @@ class AutofillAgent : public content::RenderFrameObserver,
void HidePopup();
// Formerly cached forms for all frames, now only caches forms for the current
- // frame. TODO(estade): simplify |FormCache| to only work with a single frame.
+ // frame.
FormCache form_cache_;
PasswordAutofillAgent* password_autofill_agent_; // Weak reference.
« no previous file with comments | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698