components/autofill/content/browser/request_autocomplete_manager_unittest.cc - Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/request_autocomplete_manager_unittest.cc

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix init order Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/request_autocomplete_manager.cc ('k') | components/autofill/content/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/request_autocomplete_manager_unittest.cc

diff --git a/components/autofill/content/browser/request_autocomplete_manager_unittest.cc b/components/autofill/content/browser/request_autocomplete_manager_unittest.cc

index 8fe2928e64fd9c87b7ed3653d82b177768f86d5f..f2631453fca5bb0453b927fbb04ef93ee8951779 100644

--- a/components/autofill/content/browser/request_autocomplete_manager_unittest.cc

+++ b/components/autofill/content/browser/request_autocomplete_manager_unittest.cc

@@ -45,7 +45,7 @@ class CustomTestAutofillClient : public TestAutofillClient {

~CustomTestAutofillClient() override {}

void ShowRequestAutocompleteDialog(const FormData& form,

- const GURL& source_url,

+ content::RenderFrameHost* rfh,

const ResultCallback& callback) override {

if (should_simulate_success_) {

FormStructure form_structure(form);

@@ -140,7 +140,7 @@ class RequestAutocompleteManagerTest :

TEST_F(RequestAutocompleteManagerTest, OnRequestAutocompleteSuccess) {

blink::WebFormElement::AutocompleteResult result;

- request_autocomplete_manager_->OnRequestAutocomplete(FormData(), GURL());

+ request_autocomplete_manager_->OnRequestAutocomplete(FormData());

EXPECT_TRUE(GetAutocompleteResultMessage(&result));

EXPECT_EQ(blink::WebFormElement::AutocompleteResultSuccess, result);

}

@@ -148,7 +148,7 @@ TEST_F(RequestAutocompleteManagerTest, OnRequestAutocompleteSuccess) {

TEST_F(RequestAutocompleteManagerTest, OnRequestAutocompleteCancel) {

blink::WebFormElement::AutocompleteResult result;

autofill_client_.set_should_simulate_success(false);

- request_autocomplete_manager_->OnRequestAutocomplete(FormData(), GURL());

+ request_autocomplete_manager_->OnRequestAutocomplete(FormData());

EXPECT_TRUE(GetAutocompleteResultMessage(&result));

EXPECT_EQ(blink::WebFormElement::AutocompleteResultErrorDisabled, result);

}

@@ -159,7 +159,7 @@ TEST_F(RequestAutocompleteManagerTest,

OnRequestAutocompleteWithAutofillDisabled) {

blink::WebFormElement::AutocompleteResult result;

driver_->mock_autofill_manager()->set_autofill_enabled(false);

- request_autocomplete_manager_->OnRequestAutocomplete(FormData(), GURL());

+ request_autocomplete_manager_->OnRequestAutocomplete(FormData());

EXPECT_TRUE(GetAutocompleteResultMessage(&result));

EXPECT_EQ(blink::WebFormElement::AutocompleteResultSuccess, result);

}