Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix init order Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 public: 140 public:
141 LegacyPasswordAutofillAgent(content::RenderView* render_view, 141 LegacyPasswordAutofillAgent(content::RenderView* render_view,
142 PasswordAutofillAgent* agent); 142 PasswordAutofillAgent* agent);
143 ~LegacyPasswordAutofillAgent() override; 143 ~LegacyPasswordAutofillAgent() override;
144 144
145 // RenderViewObserver: 145 // RenderViewObserver:
146 void OnDestruct() override; 146 void OnDestruct() override;
147 void DidStartLoading() override; 147 void DidStartLoading() override;
148 void DidStopLoading() override; 148 void DidStopLoading() override;
149 void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override; 149 void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;
150 void FrameDetached(blink::WebFrame* frame) override;
151 150
152 private: 151 private:
153 PasswordAutofillAgent* agent_; 152 PasswordAutofillAgent* agent_;
154 153
155 DISALLOW_COPY_AND_ASSIGN(LegacyPasswordAutofillAgent); 154 DISALLOW_COPY_AND_ASSIGN(LegacyPasswordAutofillAgent);
156 }; 155 };
157 friend class LegacyPasswordAutofillAgent; 156 friend class LegacyPasswordAutofillAgent;
158 157
159 // RenderFrameObserver: 158 // RenderFrameObserver:
160 bool OnMessageReceived(const IPC::Message& message) override; 159 bool OnMessageReceived(const IPC::Message& message) override;
161 void DidFinishDocumentLoad() override; 160 void DidFinishDocumentLoad() override;
162 void DidFinishLoad() override; 161 void DidFinishLoad() override;
162 void FrameDetached() override;
163 void FrameWillClose() override; 163 void FrameWillClose() override;
164 void DidCommitProvisionalLoad(bool is_new_navigation) override; 164 void DidCommitProvisionalLoad(bool is_new_navigation) override;
165 void WillSendSubmitEvent(const blink::WebFormElement& form) override; 165 void WillSendSubmitEvent(const blink::WebFormElement& form) override;
166 void WillSubmitForm(const blink::WebFormElement& form) override; 166 void WillSubmitForm(const blink::WebFormElement& form) override;
167 167
168 // Legacy RenderViewObserver: 168 // Legacy RenderViewObserver:
169 void DidStartLoading(); 169 void DidStartLoading();
170 void DidStopLoading(); 170 void DidStopLoading();
171 void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame); 171 void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame);
172 void FrameDetached(blink::WebFrame* frame);
173 172
174 // RenderView IPC handlers: 173 // RenderView IPC handlers:
175 void OnFillPasswordForm(int key, const PasswordFormFillData& form_data); 174 void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);
176 void OnSetLoggingState(bool active); 175 void OnSetLoggingState(bool active);
177 176
178 // Scans the given frame for password forms and sends them up to the browser. 177 // Scans the given frame for password forms and sends them up to the browser.
179 // If |only_visible| is true, only forms visible in the layout are sent. 178 // If |only_visible| is true, only forms visible in the layout are sent.
180 void SendPasswordForms(bool only_visible); 179 void SendPasswordForms(bool only_visible);
181 180
182 // Instructs the browser to show a pop-up suggesting which credentials could 181 // Instructs the browser to show a pop-up suggesting which credentials could
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 bool did_stop_loading_; 269 bool did_stop_loading_;
271 270
272 base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_; 271 base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;
273 272
274 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent); 273 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
275 }; 274 };
276 275
277 } // namespace autofill 276 } // namespace autofill
278 277
279 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 278 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698