Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.h

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix init order Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.h
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.h b/chrome/browser/ui/autofill/chrome_autofill_client.h
index 6080abd88f037188a2d42265e9d0e99f7bcad7dc..f22bf18715d12b0d1a8db4553b987b0b25363a5e 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.h
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.h
@@ -54,9 +54,10 @@ class ChromeAutofillClient
void ConfirmSaveCreditCard(const base::Closure& save_card_callback) override;
bool HasCreditCardScanFeature() override;
void ScanCreditCard(const CreditCardScanCallback& callback) override;
- void ShowRequestAutocompleteDialog(const FormData& form,
- const GURL& source_url,
- const ResultCallback& callback) override;
+ void ShowRequestAutocompleteDialog(
+ const FormData& form,
+ content::RenderFrameHost* render_frame_host,
+ const ResultCallback& callback) override;
void ShowAutofillPopup(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
@@ -75,6 +76,11 @@ class ChromeAutofillClient
void OnFirstUserGestureObserved() override;
// content::WebContentsObserver implementation.
+ void RenderFrameDeleted(content::RenderFrameHost* rfh) override;
+ void DidNavigateAnyFrame(
+ content::RenderFrameHost* render_frame_host,
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) override;
void WebContentsDestroyed() override;
// ZoomObserver implementation.
@@ -118,6 +124,9 @@ class ChromeAutofillClient
AutofillKeystoneBridgeWrapper* bridge_wrapper_;
#endif // defined(OS_MACOSX) && !defined(OS_IOS)
+ // The last render frame that called requestAutocomplete.
+ content::RenderFrameHost* last_rfh_to_rac_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeAutofillClient);
};

Powered by Google App Engine
This is Rietveld 408576698