Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 788243008: Sketch DM refactor. (Closed)

Created:
6 years ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sketch DM refactor. BUG=skia:3255 I think this supports everything DM used to, but has completely refactored how it works to fit the design in the bug. Configs like "tiles-gpu" are automatically wired up. I wouldn't suggest looking at this as a diff. There's just a bunch of deleted files, a few new files, and one new file that shares a name with a deleted file (DM.cpp). NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88 Committed: https://skia.googlesource.com/skia/+/748ca3bf2d170708f263693e8579e6722389d0ef

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : Allow parallel execution of non-threadsafe sinks. #

Patch Set 5 : misc #

Patch Set 6 : better, run tests #

Patch Set 7 : pdf, --config, rearrange a little #

Patch Set 8 : unused #

Patch Set 9 : snap #

Patch Set 10 : pipe #

Patch Set 11 : src and sink types in DM.cpp only #

Patch Set 12 : snap #

Patch Set 13 : write json #

Patch Set 14 : write pngs #

Patch Set 15 : snap #

Patch Set 16 : initial transform, -x and -V, --config tests #

Patch Set 17 : --config doesn't use match semantics' #

Patch Set 18 : subsets, sourceType in the path/key #

Patch Set 19 : turn on tests by default #

Patch Set 20 : unused #

Patch Set 21 : plumbing for ViaTiling #

Patch Set 22 : snap #

Patch Set 23 : take ownership #

Patch Set 24 : names #

Patch Set 25 : tiles #

Patch Set 26 : notes and formatting #

Patch Set 27 : TODO ViaMatrix #

Patch Set 28 : Build warnings #

Patch Set 29 : Handle no-gpu builds. #

Patch Set 30 : more windows #

Patch Set 31 : rebase #

Patch Set 32 : refinements #

Patch Set 33 : pdf changes mostly #

Patch Set 34 : parallelize all tests, add back timer #

Patch Set 35 : fun #

Patch Set 36 : enclaves #

Patch Set 37 : tweaks #

Patch Set 38 : smart pipelines #

Patch Set 39 : ViaMatrix #

Patch Set 40 : sinks can set the file extension #

Patch Set 41 : rebase #

Patch Set 42 : (void) is not enough #

Patch Set 43 : names, fileExtension(), disable pdf for now #

Patch Set 44 : ---tests, make skipping messages uniform #

Patch Set 45 : print more #

Patch Set 46 : better failure messages, disable a few things temporarily to try to go green #

Unified diffs Side-by-side diffs Delta from patch set Stats (+964 lines, -2037 lines) Patch
M bench/nanobench.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 2 chunks +2 lines, -9 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 1 chunk +373 lines, -223 lines 0 comments Download
D dm/DMCpuGMTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -38 lines 0 comments Download
D dm/DMCpuGMTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -56 lines 0 comments Download
D dm/DMGpuGMTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -43 lines 0 comments Download
D dm/DMGpuGMTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -67 lines 0 comments Download
D dm/DMImageTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -30 lines 0 comments Download
D dm/DMImageTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -78 lines 0 comments Download
M dm/DMJsonWriter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +4 lines, -4 lines 0 comments Download
M dm/DMJsonWriter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +1 line, -1 line 0 comments Download
D dm/DMPDFRasterizeTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -41 lines 0 comments Download
D dm/DMPDFRasterizeTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -38 lines 0 comments Download
D dm/DMPDFTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -47 lines 0 comments Download
D dm/DMPDFTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -106 lines 0 comments Download
D dm/DMPipeTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -41 lines 0 comments Download
D dm/DMPipeTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -83 lines 0 comments Download
D dm/DMQuiltTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -39 lines 0 comments Download
D dm/DMQuiltTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -98 lines 0 comments Download
D dm/DMReporter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -36 lines 0 comments Download
D dm/DMReporter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -46 lines 0 comments Download
D dm/DMSKPTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -30 lines 0 comments Download
D dm/DMSKPTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -31 lines 0 comments Download
D dm/DMSerializeTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -31 lines 0 comments Download
D dm/DMSerializeTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -44 lines 0 comments Download
A dm/DMSrcSink.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 1 chunk +177 lines, -0 lines 0 comments Download
A dm/DMSrcSink.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 1 chunk +389 lines, -0 lines 0 comments Download
D dm/DMTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -74 lines 0 comments Download
D dm/DMTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -91 lines 0 comments Download
D dm/DMTaskRunner.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -29 lines 0 comments Download
D dm/DMTaskRunner.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -17 lines 0 comments Download
D dm/DMTestTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -66 lines 0 comments Download
D dm/DMTestTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -61 lines 0 comments Download
D dm/DMUtil.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -43 lines 0 comments Download
D dm/DMUtil.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -118 lines 0 comments Download
D dm/DMWriteTask.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +0 lines, -45 lines 0 comments Download
M dm/DMWriteTask.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -189 lines 0 comments Download
D dm/README View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -27 lines 0 comments Download
M gyp/dm.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 2 chunks +2 lines, -15 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 1 chunk +2 lines, -2 lines 0 comments Download
M tools/timer/Timer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 2 chunks +3 lines, -0 lines 0 comments Download
M tools/timer/Timer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (9 generated)
mtklein
6 years ago (2014-12-18 19:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788243008/510001
6 years ago (2014-12-18 19:26:40 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-18 19:26:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788243008/530001
6 years ago (2014-12-18 19:46:03 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-18 19:46:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1265)
6 years ago (2014-12-18 19:51:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788243008/570001
6 years ago (2014-12-18 19:56:19 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-18 19:56:20 UTC) #14
mtklein
I'm going to land this to get some large-scale testing in, then revert it once ...
5 years, 11 months ago (2015-01-15 16:18:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788243008/850001
5 years, 11 months ago (2015-01-15 16:20:38 UTC) #18
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-15 16:20:40 UTC) #19
mtklein
On 2015/01/15 16:20:40, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 11 months ago (2015-01-15 16:21:28 UTC) #20
commit-bot: I haz the power
Committed patchset #45 (id:850001) as https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88
5 years, 11 months ago (2015-01-15 16:30:30 UTC) #21
mtklein
A revert of this CL (patchset #45 id:850001) has been created in https://codereview.chromium.org/853883004/ by mtklein@google.com. ...
5 years, 11 months ago (2015-01-15 18:14:19 UTC) #22
mtklein
On 2015/01/15 18:14:19, mtklein wrote: > A revert of this CL (patchset #45 id:850001) has ...
5 years, 11 months ago (2015-01-15 18:45:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788243008/870001
5 years, 11 months ago (2015-01-15 18:46:31 UTC) #25
commit-bot: I haz the power
Committed patchset #46 (id:870001) as https://skia.googlesource.com/skia/+/748ca3bf2d170708f263693e8579e6722389d0ef
5 years, 11 months ago (2015-01-15 18:56:17 UTC) #26
Stephen White
5 years, 11 months ago (2015-01-15 20:14:42 UTC) #27
Message was sent while issue was closed.
On 2015/01/15 18:56:17, I haz the power (commit-bot) wrote:
> Committed patchset #46 (id:870001) as
> https://skia.googlesource.com/skia/+/748ca3bf2d170708f263693e8579e6722389d0ef

Just FYI, this seems to have caused the GPU versions of unit tests not to run.
e.g., 

before:

out/Debug/dm --match TestNegativeBlurSigmaGPU
0 GMs x 7 configs, 1 tests, 0 pictures, 0 images
0 tasks left

after:

out/Debug/dm --match TestNegativeBlurSigmaGPU
Skipping nonrendering: Don't understand 'nonrendering'.
Skipping angle: Don't understand 'angle'.
Skipping nvprmsaa4: Could not create a surface.
0 srcs * 3 sinks + 0 tests == 0 tasks

Powered by Google App Engine
This is Rietveld 408576698