dm/DMJsonWriter.h - Issue 788243008: Sketch DM refactor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMJsonWriter.h

Issue 788243008: Sketch DM refactor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: better failure messages, disable a few things temporarily to try to go green Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMJsonWriter.h

diff --git a/dm/DMJsonWriter.h b/dm/DMJsonWriter.h

index 66ce530624b36841b833fa9d999aea8768715922..58d85d358debf177ad63029280edf502b4e1393c 100644

--- a/dm/DMJsonWriter.h

+++ b/dm/DMJsonWriter.h

@@ -23,11 +23,11 @@ public:

* Info describing a single run.

struct BitmapResult {

- SkString name; // E.g. "ninepatch-stretch", "desk-gws_skp"

- SkString config; // "gpu", "8888"

- SkString mode; // "direct", "default-tilegrid", "pipe"

- SkString sourceType; // "GM", "SKP"

+ SkString name; // E.g. "ninepatch-stretch", "desk_gws.skp"

+ SkString config; // "gpu", "8888", "serialize", "pipe"

+ SkString sourceType; // "gm", "skp", "image"

SkString md5; // In ASCII, so 32 bytes long.

+ SkString ext; // Extension of file we wrote: "png", "pdf", ...

};

/**

« no previous file with comments | « dm/DMImageTask.cpp ('k') | dm/DMJsonWriter.cpp » ('j') | no next file with comments »