Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2716)

Unified Diff: dm/DMReporter.cpp

Issue 788243008: Sketch DM refactor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: better failure messages, disable a few things temporarily to try to go green Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMReporter.h ('k') | dm/DMSKPTask.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMReporter.cpp
diff --git a/dm/DMReporter.cpp b/dm/DMReporter.cpp
deleted file mode 100644
index 7b2cea8136f32f82d1385f4ee3b2d16574c983ef..0000000000000000000000000000000000000000
--- a/dm/DMReporter.cpp
+++ /dev/null
@@ -1,46 +0,0 @@
-#include "DMReporter.h"
-
-#include "SkDynamicAnnotations.h"
-#include "SkCommonFlags.h"
-#include "OverwriteLine.h"
-#include "ProcStats.h"
-
-namespace DM {
-
-void Reporter::printStatus(SkString name, SkMSec timeMs) const {
- if (FLAGS_quiet) {
- return;
- }
-
- // It's okay if these are a little off---they're just for show---so we can read unprotectedly.
- const int32_t failed = SK_ANNOTATE_UNPROTECTED_READ(fFailed);
- const int32_t pending = SK_ANNOTATE_UNPROTECTED_READ(fPending) - 1;
-
- SkString status;
- status.printf("%s%d tasks left", FLAGS_verbose ? "\n" : kSkOverwriteLine, pending);
- if (failed > 0) {
- status.appendf(", %d failed", failed);
- }
- if (FLAGS_verbose) {
- int max_rss_mb = sk_tools::getMaxResidentSetSizeMB();
- if (max_rss_mb >= 0) {
- status.appendf("\t%4dM peak", max_rss_mb);
- }
- status.appendf("\t%5dms\t%s", timeMs, name.c_str());
- }
- SkDebugf("%s", status.c_str());
-}
-
-void Reporter::fail(SkString msg) {
- sk_atomic_inc(&fFailed);
-
- SkAutoMutexAcquire writer(&fMutex);
- fFailures.push_back(msg);
-}
-
-void Reporter::getFailures(SkTArray<SkString>* failures) const {
- SkAutoMutexAcquire reader(&fMutex);
- *failures = fFailures;
-}
-
-} // namespace DM
« no previous file with comments | « dm/DMReporter.h ('k') | dm/DMSKPTask.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698