|
Parent the AppInfoDialog using a ModalDialogHost
On Mac (both with and without MacViews) web_contents()->
GetTopLevelNativeWindow() can return NULL. So it is not valid for (e.g.)
extension_settings_handler.cc use this as a parent window for the
AppInfoDialog.
Also, in general, parenting off a gfx::NativeWindow is bad, since the
lifetime is hard to control.
This CL introduces
- CreateModalDialogViews(views::DialogDelegate*, web_modal::ModalDialogHost*)
which will eventually replace
- CreateBrowserModalDialogViews(views::DialogDelegate*, gfx::NativeView);
BUG=
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+146 lines, -87 lines) |
Patch |
 |
M |
chrome/browser/ui/app_list/app_list_controller_delegate.h
|
View
|
|
2 chunks |
+11 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/app_list_controller_delegate.cc
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/app_list_controller_delegate_views.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_list/app_list_controller_delegate_views.cc
|
View
|
|
1 chunk |
+7 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/apps/app_info_dialog.h
|
View
|
|
2 chunks |
+8 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/app_list/app_list_controller_ash.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/app_list/app_list_controller_ash.cc
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
|
View
|
|
1 chunk |
+5 lines, -14 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
|
View
|
|
3 chunks |
+8 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
|
View
|
|
2 chunks |
+10 lines, -30 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/extensions/extension_settings_handler.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/constrained_window/constrained_window_views.h
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/constrained_window/constrained_window_views.cc
|
View
|
|
2 chunks |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/web_modal/popup_manager.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/app_list/DEPS
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
ui/app_list/app_list.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
1 comment
|
Download
|
 |
M |
ui/app_list/views/app_list_view.h
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/app_list/views/app_list_view.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/app_list/views/contents_view.h
|
View
|
|
3 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
 |
M |
ui/app_list/views/contents_view.cc
|
View
|
|
2 chunks |
+19 lines, -0 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|