Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
index 33a8aa235120bbefbf0048029e0df6d2a6435e8e..d238db3d8e60dd6ffd067f3ad7c602d93e2ddd94 100644
--- a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
@@ -5,20 +5,11 @@
#include "base/logging.h"
#include "chrome/browser/ui/apps/app_info_dialog.h"
-void ShowAppInfoInAppList(gfx::NativeWindow parent,
- const gfx::Rect& app_list_bounds,
- Profile* profile,
- const extensions::Extension* app,
- const base::Closure& close_callback) {
- // TODO(sashab): Implement the App Info dialog on Mac.
- NOTIMPLEMENTED();
-}
-
-void ShowAppInfoInNativeDialog(gfx::NativeWindow parent,
- const gfx::Size& size,
- Profile* profile,
- const extensions::Extension* app,
- const base::Closure& close_callback) {
+void ShowAppInfoModally(web_modal::ModalDialogHost* host,
+ const gfx::Size& size,
+ Profile* profile,
+ const extensions::Extension* app,
+ const base::Closure& close_callback) {
// TODO(sashab): Implement the App Info dialog on Mac.
NOTIMPLEMENTED();
}

Powered by Google App Engine
This is Rietveld 408576698