Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc ('k') | components/constrained_window/constrained_window_views.h » ('j') | ui/app_list/app_list.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1d4b6f7de0f062e4bbce267651b9cc8c35d9fc94..5ac29435415c9ec4d459f26ec59710c011508090 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -61,6 +61,8 @@
#include "chrome/grit/generated_resources.h"
#include "components/google/core/browser/google_util.h"
#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/web_modal/popup_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_host.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/notification_types.h"
@@ -1233,8 +1235,8 @@ void ExtensionSettingsHandler::HandlePermissionsMessage(
const int kAppInfoDialogWidth = 380;
const int kAppInfoDialogHeight = 490;
- ShowAppInfoInNativeDialog(
- web_contents()->GetTopLevelNativeWindow(),
+ ShowAppInfoModally(
+ web_modal::PopupManager::FromWebContents(web_contents())->host(),
gfx::Size(kAppInfoDialogWidth, kAppInfoDialogHeight),
Profile::FromWebUI(web_ui()), extension,
base::Bind(&BrokerDelegate::AppInfoDialogClosed,
« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc ('k') | components/constrained_window/constrained_window_views.h » ('j') | ui/app_list/app_list.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698