Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4213)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
index 84112a38277a47a9714a38216329e1a59369ffb8..6820c55b80077b07dc14ea7fd72672f01c83d154 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
@@ -25,11 +25,11 @@
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
-AppInfoFooterPanel::AppInfoFooterPanel(gfx::NativeWindow parent_window,
+AppInfoFooterPanel::AppInfoFooterPanel(gfx::NativeView parent_view,
Profile* profile,
const extensions::Extension* app)
: AppInfoPanel(profile, app),
- parent_window_(parent_window),
+ parent_view_(parent_view),
create_shortcuts_button_(NULL),
pin_to_shelf_button_(NULL),
unpin_from_shelf_button_(NULL),
@@ -145,7 +145,7 @@ void AppInfoFooterPanel::CreateShortcuts() {
bool AppInfoFooterPanel::CanCreateShortcuts() const {
// Ash platforms can't create shortcuts, and extensions can't have shortcuts.
return !app_->is_extension() &&
- (chrome::GetHostDesktopTypeForNativeWindow(parent_window_) !=
+ (chrome::GetHostDesktopTypeForNativeView(parent_view_) !=
chrome::HOST_DESKTOP_TYPE_ASH);
}
@@ -165,7 +165,7 @@ void AppInfoFooterPanel::SetPinnedToShelf(bool value) {
bool AppInfoFooterPanel::CanSetPinnedToShelf() const {
// Non-Ash platforms don't have a shelf.
- if (chrome::GetHostDesktopTypeForNativeWindow(parent_window_) !=
+ if (chrome::GetHostDesktopTypeForNativeView(parent_view_) !=
chrome::HOST_DESKTOP_TYPE_ASH) {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698