Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: chrome/browser/ui/apps/app_info_dialog.h

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/apps/app_info_dialog.h
diff --git a/chrome/browser/ui/apps/app_info_dialog.h b/chrome/browser/ui/apps/app_info_dialog.h
index 35989485281d5affe94a9b4534f359d2a86dfef7..0abf5598beae2739d99e8c9713301548912ddab2 100644
--- a/chrome/browser/ui/apps/app_info_dialog.h
+++ b/chrome/browser/ui/apps/app_info_dialog.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_
#include "base/callback_forward.h"
+#include "components/web_modal/modal_dialog_host.h"
#include "ui/gfx/native_widget_types.h"
class Profile;
@@ -27,18 +28,12 @@ enum AppInfoLaunchSource {
};
// Shows the chrome app information as a frameless window for the given |app|
-// and |profile| at the given |app_list_bounds|. Appears 'inside' the app list.
-void ShowAppInfoInAppList(gfx::NativeWindow parent,
- const gfx::Rect& app_list_bounds,
- Profile* profile,
- const extensions::Extension* app,
- const base::Closure& close_callback);
-
-// Shows the chrome app information in a native dialog box of the given |size|.
-void ShowAppInfoInNativeDialog(gfx::NativeWindow parent,
- const gfx::Size& size,
- Profile* profile,
- const extensions::Extension* app,
- const base::Closure& close_callback);
+// and |profile|. Uses |host| to determine position and bounds. Observes |host|
+// and closes itself when |host| is destroyed.
+void ShowAppInfoModally(web_modal::ModalDialogHost* host,
+ const gfx::Size& size,
+ Profile* profile,
+ const extensions::Extension* app,
+ const base::Closure& close_callback);
#endif // CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_

Powered by Google App Engine
This is Rietveld 408576698