Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
index 51e691b1e40d910e228f85f5b22d08497bdfb71f..0401a14d9893be3c07521fc5747cfa7ba7154420 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_APP_INFO_DIALOG_VIEWS_H_
#define CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_APP_INFO_DIALOG_VIEWS_H_
+#include "components/web_modal/modal_dialog_host.h"
#include "extensions/browser/extension_registry_observer.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/view.h"
@@ -25,9 +26,10 @@ class ScrollView;
// |extension| in the member variables in this class and all AppInfoPanel
// classes.
class AppInfoDialog : public views::View,
- public extensions::ExtensionRegistryObserver {
+ public extensions::ExtensionRegistryObserver,
+ public web_modal::ModalDialogHostObserver {
public:
- AppInfoDialog(gfx::NativeWindow parent_window,
+ AppInfoDialog(web_modal::ModalDialogHost* host,
Profile* profile,
const extensions::Extension* app);
~AppInfoDialog() override;
@@ -45,6 +47,10 @@ class AppInfoDialog : public views::View,
extensions::UninstallReason reason) override;
void OnShutdown(extensions::ExtensionRegistry* registry) override;
+ // Overridden from web_modal::ModalDialogHostObserver:
+ void OnPositionRequiresUpdate() override;
+ void OnHostDestroying() override;
+
// UI elements of the dialog.
views::View* dialog_header_;
views::ScrollView* dialog_body_;

Powered by Google App Engine
This is Rietveld 408576698