Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5644)

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate.cc

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
index 318ec8a180bddf052fe8dd05cb8fcc2ded9d63f3..45f7ac47e3ed109b1c7c09742011c33d4a83642f 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
@@ -55,8 +55,8 @@ bool AppListControllerDelegate::ForceNativeDesktop() const {
void AppListControllerDelegate::ViewClosing() {}
-gfx::Rect AppListControllerDelegate::GetAppListBounds() {
- return gfx::Rect();
+gfx::Size AppListControllerDelegate::GetAppListSize() {
+ return gfx::Size();
}
void AppListControllerDelegate::OnShowChildDialog() {
@@ -109,9 +109,9 @@ void AppListControllerDelegate::DoShowAppInfoFlow(
// Since the AppListControllerDelegate is a leaky singleton, passing its raw
// pointer around is OK.
- ShowAppInfoInAppList(
- GetAppListWindow(),
- GetAppListBounds(),
+ ShowAppInfoModally(
+ GetDialogHost(),
+ GetAppListSize(),
profile,
extension,
base::Bind(&AppListControllerDelegate::OnCloseChildDialog,

Powered by Google App Engine
This is Rietveld 408576698