chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h - Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc » ('j') | ui/app_list/app_list.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h

index 42ea8f7dae23f25b7ba4bfc822c0e4a9fca2d7d5..826f445cd09ec1aba4125e4092713d1679d6b7da 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h

@@ -34,7 +34,7 @@ class AppInfoFooterPanel

public extensions::ExtensionUninstallDialog::Delegate,

public base::SupportsWeakPtr<AppInfoFooterPanel> {

public:

- AppInfoFooterPanel(gfx::NativeWindow parent_window,

+ AppInfoFooterPanel(gfx::NativeView parent_view,

Profile* profile,

const extensions::Extension* app);

~AppInfoFooterPanel() override;

@@ -69,7 +69,7 @@ class AppInfoFooterPanel

void UninstallApp();

bool CanUninstallApp() const;

- gfx::NativeWindow parent_window_;

+ gfx::NativeView parent_view_;

// UI elements on the dialog. Elements are NULL if they are not displayed.

views::LabelButton* create_shortcuts_button_;