Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: components/constrained_window/constrained_window_views.h

Issue 719203003: Parent the AppInfoDialog using a ModalDialogHost Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window/constrained_window_views.h
diff --git a/components/constrained_window/constrained_window_views.h b/components/constrained_window/constrained_window_views.h
index ed4a82863d74c3961d79227db3821ad7cff6f4fe..80c3fb05280653a925199ba658a7da0054ced1bd 100644
--- a/components/constrained_window/constrained_window_views.h
+++ b/components/constrained_window/constrained_window_views.h
@@ -55,9 +55,19 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,
// |dialog->GetModalType()|. The modal type must be either
// ui::MODAL_TYPE_SYSTEM or ui::MODAL_TYPE_WINDOW. This places the
// dialog appropriately if |parent| is a valid browser window.
+// DEPRECATED: Use CreateModalDialogViews().
views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
gfx::NativeView parent);
+// Create a widget for |dialog| that is modal to |host|. This could be a
+// WebContents, a browser window, or another kind of ModalDialogHost. The
+// modality is given by dialog->GetModalType(), which must be
+// ui::MODAL_TYPE_SYSTEM or ui::MODAL_TYPE_WINDOW. Calls through this API will
+// not use the PopupManager, but will have their position and lifetime
+// determined by |host|.
+views::Widget* CreateModalDialogViews(views::DialogDelegate* dialog,
+ web_modal::ModalDialogHost* host);
+
} // namespace constrained window
#endif // COMPONENTS_CONSTRAINED_WINDOW_CONSTRAINED_WINDOW_VIEWS_H_

Powered by Google App Engine
This is Rietveld 408576698