Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static void installV8TestInterfaceTemplate(v8::Handle<v8::FunctionTemplate>, v8::Isolate*) inline void setObjectGroup(ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate) static void visitDOMWrapper(ScriptWrappableBase*, const v8::Persistent<v8::Object>&, v8::Isolate*) typedef void (*ResolveWrapperReachabilityFunction)(ScriptWrappableBase* internalPointer, const v8::Persistent<v8::Object>&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-11-03 07:29:53 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-03 07:31:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696203002/1
6 years, 1 month ago (2014-11-03 09:34:49 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 10:43:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184787

Powered by Google App Engine
This is Rietveld 408576698