Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/WrapperTypeInfo.h ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 v8::Handle<v8::Object> wrapper = info.Holder(); 61 v8::Handle<v8::Object> wrapper = info.Holder();
62 62
63 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), wrapper, ScriptState::current(info.GetIsolate())); 63 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), wrapper, ScriptState::current(info.GetIsolate()));
64 RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(cal lback.release()); 64 RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(cal lback.release());
65 65
66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate()); 66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate());
67 info.GetReturnValue().Set(wrapper); 67 info.GetReturnValue().Set(wrapper);
68 } 68 }
69 69
70 void V8MutationObserver::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBas e, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate) 70 void V8MutationObserver::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappableBa se* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper)
71 { 71 {
72 MutationObserver* observer = scriptWrappableBase->toImpl<MutationObserver>() ; 72 MutationObserver* observer = scriptWrappableBase->toImpl<MutationObserver>() ;
73 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes = observer->getOb servedNodes(); 73 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes = observer->getOb servedNodes();
74 for (WillBeHeapHashSet<RawPtrWillBeMember<Node> >::iterator it = observedNod es.begin(); it != observedNodes.end(); ++it) { 74 for (WillBeHeapHashSet<RawPtrWillBeMember<Node> >::iterator it = observedNod es.begin(); it != observedNodes.end(); ++it) {
75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(isolate, *it))); 75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(isolate, *it)));
76 isolate->SetReferenceFromGroup(id, wrapper); 76 isolate->SetReferenceFromGroup(id, wrapper);
77 } 77 }
78 } 78 }
79 79
80 } // namespace blink 80 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/WrapperTypeInfo.h ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698