Source/bindings/tests/results/core/V8TestInterface3.h - Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface3.h

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterface5.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface3.h

diff --git a/Source/bindings/tests/results/core/V8TestInterface3.h b/Source/bindings/tests/results/core/V8TestInterface3.h

index 542491d0abccc41b1faaadd677ec63493be9d92b..b80e371a43f5c7024d77072708c5e1f15a89fca0 100644

--- a/Source/bindings/tests/results/core/V8TestInterface3.h

+++ b/Source/bindings/tests/results/core/V8TestInterface3.h

@@ -32,7 +32,7 @@ public:

static void trace(Visitor* visitor, ScriptWrappableBase* scriptWrappableBase)

{

}

- static void visitDOMWrapper(ScriptWrappableBase*, const v8::Persistent<v8::Object>&, v8::Isolate*);

+ static void visitDOMWrapper(v8::Isolate*, ScriptWrappableBase*, const v8::Persistent<v8::Object>&);

static void indexedPropertyGetterCustom(uint32_t, const v8::PropertyCallbackInfo<v8::Value>&);

static void indexedPropertySetterCustom(uint32_t, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<v8::Value>&);

static void indexedPropertyDeleterCustom(uint32_t, const v8::PropertyCallbackInfo<v8::Boolean>&);