Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterface2.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterface2.cpp b/Source/bindings/tests/results/core/V8TestInterface2.cpp
index 46323f9348c855fbb5d263e7c5ada7d7838c78ba..30c14706504533ae156ca2c5ecf16ae882d08a59 100644
--- a/Source/bindings/tests/results/core/V8TestInterface2.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterface2.cpp
@@ -412,7 +412,7 @@ static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::A
} // namespace TestInterface2V8Internal
-void V8TestInterface2::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
+void V8TestInterface2::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper)
{
TestInterface2* impl = scriptWrappableBase->toImpl<TestInterface2>();
// The ownerNode() method may return a reference or a pointer.
@@ -421,7 +421,7 @@ void V8TestInterface2::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase,
isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(root)), wrapper);
return;
}
- setObjectGroup(scriptWrappableBase, wrapper, isolate);
+ setObjectGroup(isolate, scriptWrappableBase, wrapper);
}
static const V8DOMConfiguration::MethodConfiguration V8TestInterface2Methods[] = {
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface2.h ('k') | Source/bindings/tests/results/core/V8TestInterface3.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698