Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 v8SetReturnValue(info, wrapper); 563 v8SetReturnValue(info, wrapper);
564 } 564 }
565 565
566 {% endif %} 566 {% endif %}
567 {% endblock %} 567 {% endblock %}
568 568
569 569
570 {##############################################################################} 570 {##############################################################################}
571 {% block visit_dom_wrapper %} 571 {% block visit_dom_wrapper %}
572 {% if reachable_node_function or set_wrapper_reference_to_list %} 572 {% if reachable_node_function or set_wrapper_reference_to_list %}
573 void {{v8_class}}::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase, con st v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate) 573 void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappableBase* sc riptWrappableBase, const v8::Persistent<v8::Object>& wrapper)
574 { 574 {
575 {{cpp_class}}* impl = scriptWrappableBase->toImpl<{{cpp_class}}>(); 575 {{cpp_class}}* impl = scriptWrappableBase->toImpl<{{cpp_class}}>();
576 {% if set_wrapper_reference_to_list %} 576 {% if set_wrapper_reference_to_list %}
577 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper); 577 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
578 V8WrapperInstantiationScope scope(creationContext, isolate); 578 V8WrapperInstantiationScope scope(creationContext, isolate);
579 {% for set_wrapper_reference_to in set_wrapper_reference_to_list %} 579 {% for set_wrapper_reference_to in set_wrapper_reference_to_list %}
580 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}(); 580 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}();
581 if ({{set_wrapper_reference_to.name}}) { 581 if ({{set_wrapper_reference_to.name}}) {
582 if (!DOMDataStore::containsWrapper<{{set_wrapper_reference_to.v8_type}}> ({{set_wrapper_reference_to.name}}, isolate)) 582 if (!DOMDataStore::containsWrapper<{{set_wrapper_reference_to.v8_type}}> ({{set_wrapper_reference_to.name}}, isolate))
583 {{set_wrapper_reference_to.name}}->wrap(creationContext, isolate); 583 {{set_wrapper_reference_to.name}}->wrap(creationContext, isolate);
584 DOMDataStore::setWrapperReference<{{set_wrapper_reference_to.v8_type}}>( wrapper, {{set_wrapper_reference_to.name}}, isolate); 584 DOMDataStore::setWrapperReference<{{set_wrapper_reference_to.v8_type}}>( wrapper, {{set_wrapper_reference_to.name}}, isolate);
585 } 585 }
586 {% endfor %} 586 {% endfor %}
587 {% endif %} 587 {% endif %}
588 {% if reachable_node_function %} 588 {% if reachable_node_function %}
589 // The {{reachable_node_function}}() method may return a reference or a poin ter. 589 // The {{reachable_node_function}}() method may return a reference or a poin ter.
590 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) { 590 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) {
591 Node* root = V8GCController::opaqueRootForGC(isolate, owner); 591 Node* root = V8GCController::opaqueRootForGC(isolate, owner);
592 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 592 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
593 return; 593 return;
594 } 594 }
595 {% endif %} 595 {% endif %}
596 setObjectGroup(scriptWrappableBase, wrapper, isolate); 596 setObjectGroup(isolate, scriptWrappableBase, wrapper);
597 } 597 }
598 598
599 {% endif %} 599 {% endif %}
600 {% endblock %} 600 {% endblock %}
601 601
602 602
603 {##############################################################################} 603 {##############################################################################}
604 {% block shadow_attributes %} 604 {% block shadow_attributes %}
605 {% from 'attributes.cpp' import attribute_configuration with context %} 605 {% from 'attributes.cpp' import attribute_configuration with context %}
606 {% if interface_name == 'Window' %} 606 {% if interface_name == 'Window' %}
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 } 1021 }
1022 1022
1023 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 1023 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
1024 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 1024 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
1025 { 1025 {
1026 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 1026 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
1027 } 1027 }
1028 {% endfor %} 1028 {% endfor %}
1029 {% endif %} 1029 {% endif %}
1030 {% endblock %} 1030 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/results/core/V8TestInterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698