Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp
index caf55fc66a368b422f88d3f33a166ad53b06e09d..359e17c3946a36c4aa28363dd7f8ffd8bacb2542 100644
--- a/Source/bindings/tests/results/core/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp
@@ -1774,7 +1774,7 @@ static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::A
} // namespace TestInterfaceImplementationV8Internal
-void V8TestInterface::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
+void V8TestInterface::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper)
{
TestInterfaceImplementation* impl = scriptWrappableBase->toImpl<TestInterfaceImplementation>();
v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
@@ -1785,7 +1785,7 @@ void V8TestInterface::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase,
referencedName->wrap(creationContext, isolate);
DOMDataStore::setWrapperReference<V8TestInterface>(wrapper, referencedName, isolate);
}
- setObjectGroup(scriptWrappableBase, wrapper, isolate);
+ setObjectGroup(isolate, scriptWrappableBase, wrapper);
}
static const V8DOMConfiguration::AttributeConfiguration V8TestInterfaceAttributes[] = {
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface.h ('k') | Source/bindings/tests/results/core/V8TestInterface2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698