Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/bindings/core/v8/V8GCController.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 if (classId == WrapperTypeInfo::NodeClassId) { 278 if (classId == WrapperTypeInfo::NodeClassId) {
279 ASSERT(V8Node::hasInstance(*wrapper, m_isolate)); 279 ASSERT(V8Node::hasInstance(*wrapper, m_isolate));
280 Node* node = V8Node::toImpl(*wrapper); 280 Node* node = V8Node::toImpl(*wrapper);
281 if (node->hasEventListeners()) 281 if (node->hasEventListeners())
282 addReferencesForNodeWithEventListeners(m_isolate, node, v8::Pers istent<v8::Object>::Cast(*value)); 282 addReferencesForNodeWithEventListeners(m_isolate, node, v8::Pers istent<v8::Object>::Cast(*value));
283 Node* root = V8GCController::opaqueRootForGC(m_isolate, node); 283 Node* root = V8GCController::opaqueRootForGC(m_isolate, node);
284 m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<in tptr_t>(root))); 284 m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<in tptr_t>(root)));
285 if (m_constructRetainedObjectInfos) 285 if (m_constructRetainedObjectInfos)
286 m_groupsWhichNeedRetainerInfo.append(root); 286 m_groupsWhichNeedRetainerInfo.append(root);
287 } else if (classId == WrapperTypeInfo::ObjectClassId) { 287 } else if (classId == WrapperTypeInfo::ObjectClassId) {
288 type->visitDOMWrapper(toScriptWrappableBase(*wrapper), v8::Persisten t<v8::Object>::Cast(*value), m_isolate); 288 type->visitDOMWrapper(m_isolate, toScriptWrappableBase(*wrapper), v8 ::Persistent<v8::Object>::Cast(*value));
289 } else { 289 } else {
290 ASSERT_NOT_REACHED(); 290 ASSERT_NOT_REACHED();
291 } 291 }
292 } 292 }
293 293
294 void notifyFinished() 294 void notifyFinished()
295 { 295 {
296 if (!m_constructRetainedObjectInfos) 296 if (!m_constructRetainedObjectInfos)
297 return; 297 return;
298 std::sort(m_groupsWhichNeedRetainerInfo.begin(), m_groupsWhichNeedRetain erInfo.end()); 298 std::sort(m_groupsWhichNeedRetainerInfo.begin(), m_groupsWhichNeedRetain erInfo.end());
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 Visitor* m_visitor; 502 Visitor* m_visitor;
503 }; 503 };
504 504
505 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor) 505 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor)
506 { 506 {
507 DOMWrapperTracer tracer(visitor); 507 DOMWrapperTracer tracer(visitor);
508 v8::V8::VisitHandlesWithClassIds(isolate, &tracer); 508 v8::V8::VisitHandlesWithClassIds(isolate, &tracer);
509 } 509 }
510 510
511 } // namespace blink 511 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698