Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 696203002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/modules/V8TestInterface5.cpp
diff --git a/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/Source/bindings/tests/results/modules/V8TestInterface5.cpp
index 18d1f475325ae51ade2d70d79d9540241669fe9d..3733f1011906ebe677e411fa117db19baf19a330 100644
--- a/Source/bindings/tests/results/modules/V8TestInterface5.cpp
+++ b/Source/bindings/tests/results/modules/V8TestInterface5.cpp
@@ -720,7 +720,7 @@ static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::A
} // namespace TestInterface5ImplementationV8Internal
-void V8TestInterface5::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
+void V8TestInterface5::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappableBase* scriptWrappableBase, const v8::Persistent<v8::Object>& wrapper)
{
TestInterface5Implementation* impl = scriptWrappableBase->toImpl<TestInterface5Implementation>();
v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
@@ -731,7 +731,7 @@ void V8TestInterface5::visitDOMWrapper(ScriptWrappableBase* scriptWrappableBase,
referencedName->wrap(creationContext, isolate);
DOMDataStore::setWrapperReference<V8TestInterface5>(wrapper, referencedName, isolate);
}
- setObjectGroup(scriptWrappableBase, wrapper, isolate);
+ setObjectGroup(isolate, scriptWrappableBase, wrapper);
}
static const V8DOMConfiguration::AttributeConfiguration V8TestInterface5Attributes[] = {
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698