|
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG= 417463
R=msw@chromium.org
Committed: https://crrev.com/ff08c7cc4430e6d45e7c39751199d58a54ba7296
Cr-Commit-Position: refs/heads/master@{#301550}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+708 lines, -824 lines) |
Patch |
 |
M |
chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/chrome_views_delegate.h
|
View
|
|
1 chunk |
+23 lines, -24 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/collected_cookies_views.h
|
View
|
|
2 chunks |
+14 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/collected_cookies_views.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/color_chooser_aura.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/confirm_bubble_views.h
|
View
|
|
1 chunk |
+9 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
|
View
|
|
4 chunks |
+26 lines, -36 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/constrained_window_views_browsertest.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/content_setting_bubble_contents.h
|
View
|
|
3 chunks |
+9 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/content_setting_bubble_contents.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/cookie_info_view.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/create_application_shortcut_view.h
|
View
|
|
3 chunks |
+13 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/create_application_shortcut_view.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/critical_notification_bubble_view.h
|
View
|
|
1 chunk |
+7 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/crypto_module_password_dialog_view.h
|
View
|
|
1 chunk |
+11 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/desktop_media_picker_views.h
|
View
|
|
7 chunks |
+36 lines, -37 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/detachable_toolbar_view.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/dropdown_bar_host.h
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/dropdown_bar_view.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/dropdown_bar_view.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/edit_search_engine_dialog.h
|
View
|
|
2 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/external_protocol_dialog.h
|
View
|
|
1 chunk |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/find_bar_host.h
|
View
|
|
4 chunks |
+34 lines, -39 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/find_bar_view.h
|
View
|
|
4 chunks |
+12 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/first_run_bubble.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/first_run_bubble_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/first_run_dialog.h
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/fullscreen_exit_bubble_views.h
|
View
|
|
2 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/global_error_bubble_view.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/hung_renderer_view.h
|
View
|
|
4 chunks |
+19 lines, -22 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/importer/import_lock_dialog_view.h
|
View
|
|
1 chunk |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/javascript_app_modal_dialog_views.h
|
View
|
|
1 chunk |
+21 lines, -22 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/javascript_app_modal_event_blocker_x11.h
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/load_complete_listener.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/login_prompt_views.cc
|
View
|
|
5 chunks |
+18 lines, -27 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/login_view.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/menu_model_adapter_test.cc
|
View
|
|
8 chunks |
+37 lines, -75 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/menu_test_base.h
|
View
|
|
2 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc
|
View
|
|
9 chunks |
+39 lines, -39 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/open_pdf_in_reader_bubble_view.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/outdated_upgrade_bubble_view.h
|
View
|
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/pdf_password_dialog.cc
|
View
|
|
1 chunk |
+11 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h
|
View
|
|
2 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/sad_tab_view.h
|
View
|
|
1 chunk |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/screen_capture_notification_ui_views.cc
|
View
|
|
2 chunks |
+16 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/session_crashed_bubble_view.h
|
View
|
|
2 chunks |
+19 lines, -23 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/session_crashed_bubble_view.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/signed_certificate_timestamp_info_view.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/signed_certificate_timestamps_views.h
|
View
|
|
2 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/signed_certificate_timestamps_views.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/simple_message_box_views.cc
|
View
|
|
1 chunk |
+11 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/ssl_client_certificate_selector.h
|
View
|
|
1 chunk |
+14 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/ssl_client_certificate_selector.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
|
View
|
|
11 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/status_bubble_views.h
|
View
|
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/status_bubble_views.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.h
|
View
|
|
2 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/status_icons/status_tray_linux.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
|
View
|
|
1 chunk |
+13 lines, -14 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tab_icon_view.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tab_modal_confirm_dialog_views.h
|
View
|
|
1 chunk |
+15 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/task_manager_view.cc
|
View
|
|
3 chunks |
+38 lines, -43 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/update_recommended_message_box.h
|
View
|
|
1 chunk |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/validation_message_bubble_delegate.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/validation_message_bubble_view.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
|
View
|
|
8 chunks |
+12 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/web_dialog_view_browsertest.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|