chrome/browser/ui/views/signed_certificate_timestamps_views.h - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/signed_certificate_timestamps_views.h

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/signed_certificate_timestamp_info_view.h ('k') | chrome/browser/ui/views/signed_certificate_timestamps_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/signed_certificate_timestamps_views.h

diff --git a/chrome/browser/ui/views/signed_certificate_timestamps_views.h b/chrome/browser/ui/views/signed_certificate_timestamps_views.h

index 7b1f3ebc91be624e5b4651267036f74346337b53..51f4d2bcd3c9baa3d8d9e3930bf8a12835bf8e66 100644

--- a/chrome/browser/ui/views/signed_certificate_timestamps_views.h

+++ b/chrome/browser/ui/views/signed_certificate_timestamps_views.h

@@ -33,16 +33,16 @@ class SignedCertificateTimestampsViews : public views::DialogDelegateView,

SignedCertificateTimestampsViews(

content::WebContents* web_contents,

const net::SignedCertificateTimestampAndStatusList& sct_list);

- virtual ~SignedCertificateTimestampsViews();

+ ~SignedCertificateTimestampsViews() override;

// views::DialogDelegate:

- virtual base::string16 GetWindowTitle() const override;

- virtual int GetDialogButtons() const override;

- virtual ui::ModalType GetModalType() const override;

+ base::string16 GetWindowTitle() const override;

+ int GetDialogButtons() const override;

+ ui::ModalType GetModalType() const override;

// views::View:

- virtual void ViewHierarchyChanged(const ViewHierarchyChangedDetails& details)

- override;

+ void ViewHierarchyChanged(

+ const ViewHierarchyChangedDetails& details) override;

private:

void Init();

@@ -50,12 +50,12 @@ class SignedCertificateTimestampsViews : public views::DialogDelegateView,

void ShowSCTInfo(int sct_index);

// views::ComboboxListener:

- virtual void OnPerformAction(views::Combobox* combobox) override;

+ void OnPerformAction(views::Combobox* combobox) override;

// content::NotificationObserver:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

SignedCertificateTimestampInfoView* sct_info_view_;