chrome/browser/ui/views/simple_message_box_views.cc - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/signed_certificate_timestamps_views.cc ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index f9e2bd2b492ee233139aa4afe354111b112e899e..3812aee7459426435b3702e1aa701fbda33cfa27 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -35,24 +35,23 @@ class SimpleMessageBoxViews : public views::DialogDelegate {

const base::string16& yes_text,

const base::string16& no_text,

bool is_system_modal);

- virtual ~SimpleMessageBoxViews();

+ ~SimpleMessageBoxViews() override;

MessageBoxResult RunDialogAndGetResult();

// Overridden from views::DialogDelegate:

- virtual int GetDialogButtons() const override;

- virtual base::string16 GetDialogButtonLabel(

- ui::DialogButton button) const override;

- virtual bool Cancel() override;

- virtual bool Accept() override;

+ int GetDialogButtons() const override;

+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;

+ bool Cancel() override;

+ bool Accept() override;

// Overridden from views::WidgetDelegate:

- virtual base::string16 GetWindowTitle() const override;

- virtual void DeleteDelegate() override;

- virtual ui::ModalType GetModalType() const override;

- virtual views::View* GetContentsView() override;

- virtual views::Widget* GetWidget() override;

- virtual const views::Widget* GetWidget() const override;

+ base::string16 GetWindowTitle() const override;

+ void DeleteDelegate() override;

+ ui::ModalType GetModalType() const override;

+ views::View* GetContentsView() override;

+ views::Widget* GetWidget() override;

+ const views::Widget* GetWidget() const override;

private: