chrome/browser/ui/views/status_bubble_views.h - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/status_bubble_views.h

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc ('k') | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/status_bubble_views.h

diff --git a/chrome/browser/ui/views/status_bubble_views.h b/chrome/browser/ui/views/status_bubble_views.h

index 8ec3731e75233a83715961987f18db45bd8c3852..231306a81e8e794456be016aaac0c0c4f1b2d756 100644

--- a/chrome/browser/ui/views/status_bubble_views.h

+++ b/chrome/browser/ui/views/status_bubble_views.h

@@ -35,7 +35,7 @@ class StatusBubbleViews : public StatusBubble {

// |base_view| is the view that this bubble is positioned relative to.

explicit StatusBubbleViews(views::View* base_view);

- virtual ~StatusBubbleViews();

+ ~StatusBubbleViews() override;

views::View* base_view() { return base_view_; }

@@ -54,12 +54,11 @@ class StatusBubbleViews : public StatusBubble {

void SetBubbleWidth(int width);

// Overridden from StatusBubble:

- virtual void SetStatus(const base::string16& status) override;

- virtual void SetURL(const GURL& url, const std::string& languages) override;

- virtual void Hide() override;

- virtual void MouseMoved(const gfx::Point& location,

- bool left_content) override;

- virtual void UpdateDownloadShelfVisibility(bool visible) override;

+ void SetStatus(const base::string16& status) override;

+ void SetURL(const GURL& url, const std::string& languages) override;

+ void Hide() override;

+ void MouseMoved(const gfx::Point& location, bool left_content) override;

+ void UpdateDownloadShelfVisibility(bool visible) override;

views::Widget* GetPopupForTest() { return popup(); }