chrome/browser/ui/views/crypto_module_password_dialog_view.h - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/crypto_module_password_dialog_view.h

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/critical_notification_bubble_view.h ('k') | chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/crypto_module_password_dialog_view.h

diff --git a/chrome/browser/ui/views/crypto_module_password_dialog_view.h b/chrome/browser/ui/views/crypto_module_password_dialog_view.h

index 68ff38264a3eceadb063705d49136b91f9cb8b11..eb243fb16a57c3b90e98bd9f7cf7abc2b34a7a9c 100644

--- a/chrome/browser/ui/views/crypto_module_password_dialog_view.h

+++ b/chrome/browser/ui/views/crypto_module_password_dialog_view.h

@@ -28,27 +28,26 @@ class CryptoModulePasswordDialogView : public views::DialogDelegateView,

const std::string& server,

const CryptoModulePasswordCallback& callback);

- virtual ~CryptoModulePasswordDialogView();

+ ~CryptoModulePasswordDialogView() override;

private:

FRIEND_TEST_ALL_PREFIXES(CryptoModulePasswordDialogViewTest, TestAccept);

// views::WidgetDelegate:

- virtual views::View* GetInitiallyFocusedView() override;

- virtual ui::ModalType GetModalType() const override;

- virtual base::string16 GetWindowTitle() const override;

+ views::View* GetInitiallyFocusedView() override;

+ ui::ModalType GetModalType() const override;

+ base::string16 GetWindowTitle() const override;

// views::DialogDelegate:

- virtual base::string16 GetDialogButtonLabel(

- ui::DialogButton button) const override;

- virtual bool Cancel() override;

- virtual bool Accept() override;

+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;

+ bool Cancel() override;

+ bool Accept() override;

// views::TextfieldController:

- virtual void ContentsChanged(views::Textfield* sender,

- const base::string16& new_contents) override;

- virtual bool HandleKeyEvent(views::Textfield* sender,

- const ui::KeyEvent& keystroke) override;

+ void ContentsChanged(views::Textfield* sender,

+ const base::string16& new_contents) override;

+ bool HandleKeyEvent(views::Textfield* sender,

+ const ui::KeyEvent& keystroke) override;

// Initialize views and layout.

void Init(const std::string& server,