chrome/browser/ui/views/sad_tab_view.h - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sad_tab_view.h

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h ('k') | chrome/browser/ui/views/screen_capture_notification_ui_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sad_tab_view.h

diff --git a/chrome/browser/ui/views/sad_tab_view.h b/chrome/browser/ui/views/sad_tab_view.h

index eb2e453011a2daeb0c9e685e8cf15a3bb7fbc0de..ac2d056c18ad8e0be1187f07177405daa61fb516 100644

--- a/chrome/browser/ui/views/sad_tab_view.h

+++ b/chrome/browser/ui/views/sad_tab_view.h

@@ -35,26 +35,25 @@ class SadTabView : public chrome::SadTab,

public views::ButtonListener {

public:

SadTabView(content::WebContents* web_contents, chrome::SadTabKind kind);

- virtual ~SadTabView();

+ ~SadTabView() override;

// Overridden from views::View:

- virtual void Layout() override;

+ void Layout() override;

// Overridden from views::LinkListener:

- virtual void LinkClicked(views::Link* source, int event_flags) override;

+ void LinkClicked(views::Link* source, int event_flags) override;

// Overridden from views::ButtonListener:

- virtual void ButtonPressed(views::Button* source,

- const ui::Event& event) override;

+ void ButtonPressed(views::Button* source, const ui::Event& event) override;

protected:

// Overridden from views::View:

- virtual void OnPaint(gfx::Canvas* canvas) override;

+ void OnPaint(gfx::Canvas* canvas) override;

private:

// Overridden from chrome::SadTab:

- virtual void Show() override;

- virtual void Close() override;

+ void Show() override;

+ void Close() override;

views::Label* CreateLabel(const base::string16& text);

views::Link* CreateLink(const base::string16& text);