Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4320)

Unified Diff: chrome/browser/ui/views/find_bar_view.h

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/find_bar_host.h ('k') | chrome/browser/ui/views/first_run_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.h
diff --git a/chrome/browser/ui/views/find_bar_view.h b/chrome/browser/ui/views/find_bar_view.h
index c9c907afc3ea936988c4931fbe5baf5b85bbeaae..8382b021f4543316fd1ef101a4dc19bb1577a04a 100644
--- a/chrome/browser/ui/views/find_bar_view.h
+++ b/chrome/browser/ui/views/find_bar_view.h
@@ -42,7 +42,7 @@ class FindBarView : public DropdownBarView,
};
explicit FindBarView(FindBarHost* host);
- virtual ~FindBarView();
+ ~FindBarView() override;
// Accessors for the text and selection displayed in the text box.
void SetFindTextAndSelectedRange(const base::string16& find_text,
@@ -65,22 +65,21 @@ class FindBarView : public DropdownBarView,
void ClearMatchCount();
// Claims focus for the text field and selects its contents.
- virtual void SetFocusAndSelection(bool select_all) override;
+ void SetFocusAndSelection(bool select_all) override;
// views::View:
- virtual void OnPaint(gfx::Canvas* canvas) override;
- virtual void Layout() override;
- virtual gfx::Size GetPreferredSize() const override;
+ void OnPaint(gfx::Canvas* canvas) override;
+ void Layout() override;
+ gfx::Size GetPreferredSize() const override;
// views::ButtonListener:
- virtual void ButtonPressed(views::Button* sender,
- const ui::Event& event) override;
+ void ButtonPressed(views::Button* sender, const ui::Event& event) override;
// views::TextfieldController:
- virtual bool HandleKeyEvent(views::Textfield* sender,
- const ui::KeyEvent& key_event) override;
- virtual void OnAfterUserAction(views::Textfield* sender) override;
- virtual void OnAfterPaste() override;
+ bool HandleKeyEvent(views::Textfield* sender,
+ const ui::KeyEvent& key_event) override;
+ void OnAfterUserAction(views::Textfield* sender) override;
+ void OnAfterPaste() override;
private:
// Starts finding |search_text|. If the text is empty, stops finding.
@@ -90,7 +89,7 @@ class FindBarView : public DropdownBarView,
void UpdateMatchCountAppearance(bool no_match);
// views::View:
- virtual void OnThemeChanged() override;
+ void OnThemeChanged() override;
// We use a hidden view to grab mouse clicks and bring focus to the find
// text box. This is because although the find text box may look like it
@@ -105,7 +104,7 @@ class FindBarView : public DropdownBarView,
: view_to_focus_on_mousedown_(view_to_focus_on_mousedown) {}
private:
- virtual bool OnMousePressed(const ui::MouseEvent& event) override;
+ bool OnMousePressed(const ui::MouseEvent& event) override;
views::Textfield* view_to_focus_on_mousedown_;
« no previous file with comments | « chrome/browser/ui/views/find_bar_host.h ('k') | chrome/browser/ui/views/first_run_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698