chrome/browser/ui/views/constrained_window_views_browsertest.cc - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_window_views_browsertest.cc

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_window_views_browsertest.cc

diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc

index ea83683ddbcf4de8fef94b45d78e6285d6d484b6..52bc448ea863fd3b1210c74d590e44495352d086 100644

--- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc

+++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc

@@ -32,13 +32,13 @@ namespace {

class TestDialog : public views::DialogDelegateView {

public:

TestDialog() { SetFocusable(true); }

- virtual ~TestDialog() {}

+ ~TestDialog() override {}

- virtual views::View* GetInitiallyFocusedView() override { return this; }

+ views::View* GetInitiallyFocusedView() override { return this; }

// Don't delete the delegate yet. Keep it around for inspection later.

- virtual void DeleteDelegate() override {}

+ void DeleteDelegate() override {}

- virtual ui::ModalType GetModalType() const override {

+ ui::ModalType GetModalType() const override {

#if defined(USE_ASH)

return ui::MODAL_TYPE_CHILD;

#else