chrome/browser/ui/views/validation_message_bubble_view.cc - Issue 680133002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/validation_message_bubble_view.cc

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/validation_message_bubble_delegate.h ('k') | chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/validation_message_bubble_view.cc

diff --git a/chrome/browser/ui/views/validation_message_bubble_view.cc b/chrome/browser/ui/views/validation_message_bubble_view.cc

index a567babca5f38f843b47f371f66603a8debadfb0..4cd54819be819a0277b33841368726f30b9e648d 100644

--- a/chrome/browser/ui/views/validation_message_bubble_view.cc

+++ b/chrome/browser/ui/views/validation_message_bubble_view.cc

@@ -22,12 +22,12 @@ class ValidationMessageBubbleImpl

const base::string16& main_text,

const base::string16& sub_text);

- virtual ~ValidationMessageBubbleImpl() {

+ ~ValidationMessageBubbleImpl() override {

if (delegate_ != NULL)

delegate_->Close();

}

- virtual void SetPositionRelativeToAnchor(

+ void SetPositionRelativeToAnchor(

content::RenderWidgetHost* widget_host,

const gfx::Rect& anchor_in_root_view) override {

if (!delegate_)

@@ -37,9 +37,7 @@ class ValidationMessageBubbleImpl

}

// ValidationMessageBubbleDelegate::Observer override:

- virtual void WindowClosing() override {

- delegate_ = NULL;

- }

+ void WindowClosing() override { delegate_ = NULL; }

private:

ValidationMessageBubbleDelegate* delegate_;