Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed)

Created:
5 years, 9 months ago by dcheng
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
dcheng, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in remoting/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=jamiewalch@chromium.org Committed: https://crrev.com/562aba59981ae3d648503827d699ae8cbbeb6111 Cr-Commit-Position: refs/heads/master@{#300472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1140 lines, -1268 lines) Patch
M remoting/base/auto_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/auto_thread_task_runner.h View 1 chunk +8 lines, -10 lines 0 comments Download
M remoting/base/compound_buffer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/base/plugin_thread_task_runner.h View 1 chunk +8 lines, -10 lines 0 comments Download
M remoting/base/url_request_context_getter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/base/vlog_net_log.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/vlog_net_log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/audio_decode_scheduler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/audio_player_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M remoting/client/chromoting_client.h View 2 chunks +11 lines, -16 lines 0 comments Download
M remoting/client/frame_consumer_proxy.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/client/key_event_mapper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 2 chunks +25 lines, -28 lines 0 comments Download
M remoting/client/plugin/delegating_signal_strategy.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/client/plugin/media_source_video_renderer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/media_source_video_renderer.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/client/plugin/normalizing_input_filter_cros.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/plugin/normalizing_input_filter_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_address_resolver.h View 1 chunk +5 lines, -6 lines 0 comments Download
M remoting/client/plugin/pepper_audio_player.h View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_entrypoints.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 chunk +7 lines, -6 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M remoting/client/plugin/pepper_plugin_thread_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_view.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/client/software_video_renderer.h View 2 chunks +10 lines, -11 lines 0 comments Download
M remoting/client/software_video_renderer.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/client/token_fetcher_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/codec/audio_decoder_opus.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/codec/audio_decoder_verbatim.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/codec/audio_encoder_opus.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/codec/audio_encoder_verbatim.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/codec/video_decoder_verbatim.h View 1 chunk +11 lines, -11 lines 0 comments Download
M remoting/codec/video_decoder_vpx.h View 1 chunk +11 lines, -11 lines 0 comments Download
M remoting/codec/video_encoder_verbatim.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/codec/video_encoder_vpx.h View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/basic_desktop_environment.h View 2 chunks +11 lines, -12 lines 0 comments Download
M remoting/host/cast_extension.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/cast_extension_session.h View 2 chunks +17 lines, -20 lines 0 comments Download
M remoting/host/cast_extension_session.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M remoting/host/cast_video_capturer_adapter.h View 1 chunk +11 lines, -11 lines 0 comments Download
M remoting/host/chromium_port_allocator_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.h View 3 chunks +13 lines, -14 lines 0 comments Download
M remoting/host/client_session.h View 1 chunk +22 lines, -28 lines 0 comments Download
M remoting/host/clipboard_mac.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M remoting/host/config_file_watcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/continue_window.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/continue_window_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/curtain_mode_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/daemon_process.h View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/daemon_process_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/desktop_process.h View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/host/desktop_resizer_mac.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 2 chunks +14 lines, -16 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/disconnect_window_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/dns_blackhole_checker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/fake_desktop_capturer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/fake_desktop_environment.h View 4 chunks +23 lines, -26 lines 0 comments Download
M remoting/host/fake_host_extension.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/fake_host_extension.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M remoting/host/fake_host_status_monitor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/fake_mouse_cursor_monitor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/gnubby_auth_handler_posix.h View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/host/gnubby_auth_handler_posix_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/host_change_notification_listener.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/host_event_logger_posix.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M remoting/host/host_status_logger.h View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/host_status_sender.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/host_window_proxy.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/host_window_proxy.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/in_memory_host_config.h View 1 chunk +8 lines, -10 lines 0 comments Download
M remoting/host/input_injector_mac.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/ipc_audio_capturer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 2 chunks +21 lines, -25 lines 0 comments Download
M remoting/host/ipc_host_event_logger.h View 1 chunk +10 lines, -11 lines 0 comments Download
M remoting/host/ipc_input_injector.h View 1 chunk +6 lines, -8 lines 0 comments Download
M remoting/host/ipc_mouse_cursor_monitor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/ipc_screen_controls.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/ipc_video_frame_capturer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/it2me/it2me_host.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.h View 1 chunk +9 lines, -11 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/it2me_desktop_environment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/json_host_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M remoting/host/me2me_desktop_environment.h View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/mouse_clamping_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_pipe.h View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/native_messaging/pipe_messaging_channel.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/oauth_token_getter.h View 1 chunk +9 lines, -9 lines 0 comments Download
M remoting/host/pam_authorization_factory_posix.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/pam_authorization_factory_posix.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M remoting/host/policy_hack/fake_policy_watcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_mac.mm View 1 chunk +4 lines, -8 lines 0 comments Download
M remoting/host/posix/signal_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/register_support_host_request.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/remote_input_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/resizing_host_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/resizing_host_observer_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.h View 1 chunk +11 lines, -13 lines 0 comments Download
M remoting/host/setup/host_starter.h View 2 chunks +11 lines, -11 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M remoting/host/setup/oauth_client.h View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/host/setup/service_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/shaped_desktop_capturer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/host/shaped_desktop_capturer_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M remoting/host/signaling_connector.h View 2 chunks +5 lines, -7 lines 0 comments Download
M remoting/host/single_window_desktop_environment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/single_window_desktop_environment.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/single_window_input_injector_mac.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/token_validator_base.h View 1 chunk +9 lines, -10 lines 0 comments Download
M remoting/host/token_validator_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/token_validator_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/token_validator_factory_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/video_frame_recorder.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/video_frame_recorder_host_extension.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/video_frame_recorder_host_extension.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M remoting/host/video_scheduler.h View 2 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/video_scheduler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/audio_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/audio_writer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.h View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/protocol/channel_multiplexer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +24 lines, -34 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 chunk +9 lines, -7 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.cc View 1 chunk +16 lines, -14 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.h View 2 chunks +9 lines, -10 lines 0 comments Download
M remoting/protocol/client_event_dispatcher.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/protocol/client_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/client_video_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/clipboard_echo_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/clipboard_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/clipboard_thread_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 2 chunks +8 lines, -10 lines 0 comments Download
M remoting/protocol/content_description.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/fake_authenticator.h View 3 chunks +13 lines, -15 lines 0 comments Download
M remoting/protocol/fake_datagram_socket.h View 4 chunks +13 lines, -11 lines 0 comments Download
M remoting/protocol/fake_session.h View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/protocol/fake_stream_socket.h View 4 chunks +27 lines, -25 lines 0 comments Download
M remoting/protocol/host_control_dispatcher.h View 2 chunks +7 lines, -9 lines 0 comments Download
M remoting/protocol/host_event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/host_video_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/input_event_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/input_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 chunk +19 lines, -20 lines 0 comments Download
M remoting/protocol/jingle_session_manager.h View 1 chunk +8 lines, -10 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +8 lines, -14 lines 0 comments Download
M remoting/protocol/monitored_video_stub.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/mouse_input_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.h View 1 chunk +5 lines, -6 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/pairing_authenticator_base.h View 1 chunk +8 lines, -9 lines 0 comments Download
M remoting/protocol/pairing_client_authenticator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/pairing_host_authenticator.h View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 2 chunks +10 lines, -11 lines 0 comments Download
M remoting/protocol/pseudotcp_channel_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/secure_channel_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.h View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/protocol/third_party_authenticator_base.h View 1 chunk +8 lines, -9 lines 0 comments Download
M remoting/protocol/third_party_authenticator_unittest.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M remoting/protocol/third_party_client_authenticator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/protocol/third_party_host_authenticator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/protocol/v2_authenticator.h View 1 chunk +8 lines, -9 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.h View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/signaling/iq_sender.h View 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/signaling/log_to_server.h View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 1 chunk +11 lines, -11 lines 0 comments Download
M remoting/test/fake_network_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/test/fake_port_allocator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/test/fake_port_allocator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/test/fake_socket_factory.h View 2 chunks +15 lines, -14 lines 0 comments Download
M remoting/test/fake_socket_factory.cc View 2 chunks +16 lines, -14 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 3 chunks +17 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
5 years, 9 months ago (2014-10-21 10:45:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667123002/1
5 years, 9 months ago (2014-10-21 10:48:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2014-10-21 12:30:31 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2014-10-21 13:09:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/562aba59981ae3d648503827d699ae8cbbeb6111
Cr-Commit-Position: refs/heads/master@{#300472}

Powered by Google App Engine
This is Rietveld 408576698