Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: remoting/protocol/fake_datagram_socket.h

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/fake_authenticator.h ('k') | remoting/protocol/fake_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/fake_datagram_socket.h
diff --git a/remoting/protocol/fake_datagram_socket.h b/remoting/protocol/fake_datagram_socket.h
index 0d1c4f4d952a1348f50572a4f21cc28280c65ae8..86369ae6560be1805079aeaf3370aba2993ab763 100644
--- a/remoting/protocol/fake_datagram_socket.h
+++ b/remoting/protocol/fake_datagram_socket.h
@@ -35,7 +35,7 @@ namespace protocol {
class FakeDatagramSocket : public net::Socket {
public:
FakeDatagramSocket();
- virtual ~FakeDatagramSocket();
+ ~FakeDatagramSocket() override;
const std::vector<std::string>& written_packets() const {
return written_packets_;
@@ -54,12 +54,14 @@ class FakeDatagramSocket : public net::Socket {
base::WeakPtr<FakeDatagramSocket> GetWeakPtr();
// net::Socket implementation.
- virtual int Read(net::IOBuffer* buf, int buf_len,
- const net::CompletionCallback& callback) override;
- virtual int Write(net::IOBuffer* buf, int buf_len,
- const net::CompletionCallback& callback) override;
- virtual int SetReceiveBufferSize(int32 size) override;
- virtual int SetSendBufferSize(int32 size) override;
+ int Read(net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback) override;
+ int Write(net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback) override;
+ int SetReceiveBufferSize(int32 size) override;
+ int SetSendBufferSize(int32 size) override;
private:
int CopyReadData(net::IOBuffer* buf, int buf_len);
@@ -83,7 +85,7 @@ class FakeDatagramSocket : public net::Socket {
class FakeDatagramChannelFactory : public DatagramChannelFactory {
public:
FakeDatagramChannelFactory();
- virtual ~FakeDatagramChannelFactory();
+ ~FakeDatagramChannelFactory() override;
void set_asynchronous_create(bool asynchronous_create) {
asynchronous_create_ = asynchronous_create;
@@ -102,9 +104,9 @@ class FakeDatagramChannelFactory : public DatagramChannelFactory {
FakeDatagramSocket* GetFakeChannel(const std::string& name);
// DatagramChannelFactory interface.
- virtual void CreateChannel(const std::string& name,
- const ChannelCreatedCallback& callback) override;
- virtual void CancelChannelCreation(const std::string& name) override;
+ void CreateChannel(const std::string& name,
+ const ChannelCreatedCallback& callback) override;
+ void CancelChannelCreation(const std::string& name) override;
private:
typedef std::map<std::string, base::WeakPtr<FakeDatagramSocket> > ChannelsMap;
« no previous file with comments | « remoting/protocol/fake_authenticator.h ('k') | remoting/protocol/fake_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698