Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: remoting/host/setup/host_starter.h

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/setup/host_starter.h
diff --git a/remoting/host/setup/host_starter.h b/remoting/host/setup/host_starter.h
index d990509b6534b56ca7ae8e9a20fd099e0ca75daa..5c032843d567dc0db994fd9e3f957a9be8cae0b4 100644
--- a/remoting/host/setup/host_starter.h
+++ b/remoting/host/setup/host_starter.h
@@ -34,7 +34,7 @@ class HostStarter : public gaia::GaiaOAuthClient::Delegate,
typedef base::Callback<void(Result)> CompletionCallback;
- virtual ~HostStarter();
+ ~HostStarter() override;
// Creates a HostStarter.
static scoped_ptr<HostStarter> Create(
@@ -52,23 +52,23 @@ class HostStarter : public gaia::GaiaOAuthClient::Delegate,
CompletionCallback on_done);
// gaia::GaiaOAuthClient::Delegate
- virtual void OnGetTokensResponse(const std::string& refresh_token,
- const std::string& access_token,
- int expires_in_seconds) override;
- virtual void OnRefreshTokenResponse(const std::string& access_token,
- int expires_in_seconds) override;
- virtual void OnGetUserEmailResponse(const std::string& user_email) override;
+ void OnGetTokensResponse(const std::string& refresh_token,
+ const std::string& access_token,
+ int expires_in_seconds) override;
+ void OnRefreshTokenResponse(const std::string& access_token,
+ int expires_in_seconds) override;
+ void OnGetUserEmailResponse(const std::string& user_email) override;
// remoting::ServiceClient::Delegate
- virtual void OnHostRegistered(const std::string& authorization_code) override;
- virtual void OnHostUnregistered() override;
+ void OnHostRegistered(const std::string& authorization_code) override;
+ void OnHostUnregistered() override;
// TODO(sergeyu): Following methods are members of all three delegate
// interfaces implemented in this class. Fix ServiceClient and
// GaiaUserEmailFetcher so that Delegate interfaces do not overlap (ideally
// they should be changed to use Callback<>).
- virtual void OnOAuthError() override;
- virtual void OnNetworkError(int response_code) override;
+ void OnOAuthError() override;
+ void OnNetworkError(int response_code) override;
private:
HostStarter(scoped_ptr<gaia::GaiaOAuthClient> oauth_client,
« no previous file with comments | « remoting/host/setup/daemon_controller_delegate_mac.h ('k') | remoting/host/setup/me2me_native_messaging_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698