remoting/host/setup/service_client.cc - Issue 667123002: Standardize usage of virtual/override/final in remoting/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/setup/service_client.cc

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/setup/service_client.cc

diff --git a/remoting/host/setup/service_client.cc b/remoting/host/setup/service_client.cc

index 7c4d4b4c1ce680f729fc582b173a041467f2b151..32ff37ffd3c4ebbc08b0497376c5245e37a8c997 100644

--- a/remoting/host/setup/service_client.cc

+++ b/remoting/host/setup/service_client.cc

@@ -40,11 +40,11 @@ class ServiceClient::Core

ServiceClient::Delegate* delegate);

// net::URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

private:

friend class base::RefCountedThreadSafe<Core>;

- virtual ~Core() {}

+ ~Core() override {}

enum PendingRequestType {

PENDING_REQUEST_NONE,

« no previous file with comments | « remoting/host/setup/oauth_client.h ('k') | remoting/host/shaped_desktop_capturer.h » ('j') | no next file with comments »