remoting/host/dns_blackhole_checker.h - Issue 667123002: Standardize usage of virtual/override/final in remoting/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/dns_blackhole_checker.h

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/dns_blackhole_checker.h

diff --git a/remoting/host/dns_blackhole_checker.h b/remoting/host/dns_blackhole_checker.h

index 38bc055c6170f95b9841c5fd703469542f959bcb..49d73ca78ae4a5d08e4e1c47fa72aa1711aba18d 100644

--- a/remoting/host/dns_blackhole_checker.h

+++ b/remoting/host/dns_blackhole_checker.h

@@ -25,10 +25,10 @@ class DnsBlackholeChecker : public net::URLFetcherDelegate {

DnsBlackholeChecker(

scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,

std::string talkgadget_prefix);

- virtual ~DnsBlackholeChecker();

+ ~DnsBlackholeChecker() override;

// net::URLFetcherDelegate interface.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Initiates a check the verify that the host talkgadget has not been "DNS

// blackholed" to prevent connections. If this is called again before the

« no previous file with comments | « remoting/host/disconnect_window_mac.mm ('k') | remoting/host/fake_desktop_capturer.h » ('j') | no next file with comments »