Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: remoting/base/auto_thread.h

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/base/auto_thread_task_runner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_BASE_AUTO_THREAD_H_ 5 #ifndef REMOTING_BASE_AUTO_THREAD_H_
6 #define REMOTING_BASE_AUTO_THREAD_H_ 6 #define REMOTING_BASE_AUTO_THREAD_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 const char* name, 48 const char* name,
49 scoped_refptr<AutoThreadTaskRunner> joiner, 49 scoped_refptr<AutoThreadTaskRunner> joiner,
50 base::MessageLoop::Type loop_type, 50 base::MessageLoop::Type loop_type,
51 ComInitType com_init_type); 51 ComInitType com_init_type);
52 #endif 52 #endif
53 53
54 // Construct the AutoThread. |name| identifies the thread for debugging. 54 // Construct the AutoThread. |name| identifies the thread for debugging.
55 explicit AutoThread(const char* name); 55 explicit AutoThread(const char* name);
56 56
57 // Waits for the thread to exit, and then destroys it. 57 // Waits for the thread to exit, and then destroys it.
58 virtual ~AutoThread(); 58 ~AutoThread() override;
59 59
60 // Starts the thread, running the specified type of MessageLoop. Returns 60 // Starts the thread, running the specified type of MessageLoop. Returns
61 // an AutoThreadTaskRunner through which tasks may be posted to the thread 61 // an AutoThreadTaskRunner through which tasks may be posted to the thread
62 // if successful, or NULL on failure. 62 // if successful, or NULL on failure.
63 // 63 //
64 // Note: This function can't be called on Windows with the loader lock held; 64 // Note: This function can't be called on Windows with the loader lock held;
65 // i.e. during a DllMain, global object construction or destruction, atexit() 65 // i.e. during a DllMain, global object construction or destruction, atexit()
66 // callback. 66 // callback.
67 // 67 //
68 // NOTE: You must not call this MessageLoop's Quit method directly. The 68 // NOTE: You must not call this MessageLoop's Quit method directly. The
69 // thread will exit when no references to the TaskRunner remain. 69 // thread will exit when no references to the TaskRunner remain.
70 scoped_refptr<AutoThreadTaskRunner> StartWithType( 70 scoped_refptr<AutoThreadTaskRunner> StartWithType(
71 base::MessageLoop::Type type); 71 base::MessageLoop::Type type);
72 72
73 #if defined(OS_WIN) 73 #if defined(OS_WIN)
74 // Configures the thread to initialize the specified COM apartment type. 74 // Configures the thread to initialize the specified COM apartment type.
75 // SetComInitType() must be called before Start(). 75 // SetComInitType() must be called before Start().
76 void SetComInitType(ComInitType com_init_type); 76 void SetComInitType(ComInitType com_init_type);
77 #endif 77 #endif
78 78
79 private: 79 private:
80 AutoThread(const char* name, AutoThreadTaskRunner* joiner); 80 AutoThread(const char* name, AutoThreadTaskRunner* joiner);
81 81
82 void QuitThread(scoped_refptr<base::SingleThreadTaskRunner> task_runner); 82 void QuitThread(scoped_refptr<base::SingleThreadTaskRunner> task_runner);
83 void JoinAndDeleteThread(); 83 void JoinAndDeleteThread();
84 84
85 // base::PlatformThread::Delegate methods: 85 // base::PlatformThread::Delegate methods:
86 virtual void ThreadMain() override; 86 void ThreadMain() override;
87 87
88 // Used to pass data to ThreadMain. 88 // Used to pass data to ThreadMain.
89 struct StartupData; 89 struct StartupData;
90 StartupData* startup_data_; 90 StartupData* startup_data_;
91 91
92 #if defined(OS_WIN) 92 #if defined(OS_WIN)
93 // Specifies which kind of COM apartment to initialize, if any. 93 // Specifies which kind of COM apartment to initialize, if any.
94 ComInitType com_init_type_; 94 ComInitType com_init_type_;
95 #endif 95 #endif
96 96
97 // The thread's handle. 97 // The thread's handle.
98 base::PlatformThreadHandle thread_; 98 base::PlatformThreadHandle thread_;
99 99
100 // The name of the thread. Used for debugging purposes. 100 // The name of the thread. Used for debugging purposes.
101 std::string name_; 101 std::string name_;
102 102
103 // Flag used to indicate whether MessageLoop was quit properly. 103 // Flag used to indicate whether MessageLoop was quit properly.
104 // This allows us to detect premature exit via MessageLoop::Quit(). 104 // This allows us to detect premature exit via MessageLoop::Quit().
105 bool was_quit_properly_; 105 bool was_quit_properly_;
106 106
107 // AutoThreadTaskRunner to post a task to to join & delete this thread. 107 // AutoThreadTaskRunner to post a task to to join & delete this thread.
108 scoped_refptr<AutoThreadTaskRunner> joiner_; 108 scoped_refptr<AutoThreadTaskRunner> joiner_;
109 109
110 DISALLOW_COPY_AND_ASSIGN(AutoThread); 110 DISALLOW_COPY_AND_ASSIGN(AutoThread);
111 }; 111 };
112 112
113 } // namespace remoting 113 } // namespace remoting
114 114
115 #endif // REMOTING_AUTO_THREAD_H_ 115 #endif // REMOTING_AUTO_THREAD_H_
OLDNEW
« no previous file with comments | « no previous file | remoting/base/auto_thread_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698