Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: remoting/host/setup/oauth_client.h

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/setup/me2me_native_messaging_host_unittest.cc ('k') | remoting/host/setup/service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/setup/oauth_client.h
diff --git a/remoting/host/setup/oauth_client.h b/remoting/host/setup/oauth_client.h
index b704dcd6d061ee033b89653922e0f018bd1c6172..5cc8f1f3bcfe099ac1e6cacb25db9dd7adbd7cba 100644
--- a/remoting/host/setup/oauth_client.h
+++ b/remoting/host/setup/oauth_client.h
@@ -33,7 +33,7 @@ class OAuthClient : public gaia::GaiaOAuthClient::Delegate {
OAuthClient(
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
- virtual ~OAuthClient();
+ ~OAuthClient() override;
// Redeems |auth_code| using |oauth_client_info| to obtain |refresh_token| and
// |access_token|, then uses the userinfo endpoint to obtain |user_email|.
@@ -47,15 +47,15 @@ class OAuthClient : public gaia::GaiaOAuthClient::Delegate {
CompletionCallback on_done);
// gaia::GaiaOAuthClient::Delegate
- virtual void OnGetTokensResponse(const std::string& refresh_token,
- const std::string& access_token,
- int expires_in_seconds) override;
- virtual void OnRefreshTokenResponse(const std::string& access_token,
- int expires_in_seconds) override;
- virtual void OnGetUserEmailResponse(const std::string& user_email) override;
-
- virtual void OnOAuthError() override;
- virtual void OnNetworkError(int response_code) override;
+ void OnGetTokensResponse(const std::string& refresh_token,
+ const std::string& access_token,
+ int expires_in_seconds) override;
+ void OnRefreshTokenResponse(const std::string& access_token,
+ int expires_in_seconds) override;
+ void OnGetUserEmailResponse(const std::string& user_email) override;
+
+ void OnOAuthError() override;
+ void OnNetworkError(int response_code) override;
private:
struct Request {
« no previous file with comments | « remoting/host/setup/me2me_native_messaging_host_unittest.cc ('k') | remoting/host/setup/service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698