Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: remoting/host/cast_extension_session.cc

Issue 667123002: Standardize usage of virtual/override/final in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/cast_extension_session.h ('k') | remoting/host/cast_video_capturer_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/cast_extension_session.cc
diff --git a/remoting/host/cast_extension_session.cc b/remoting/host/cast_extension_session.cc
index 1976cda88476a5314bc39f3fb8b5901ea8c9dc4c..9cc03b620943dee17663b410fb94d8d355324bd2 100644
--- a/remoting/host/cast_extension_session.cc
+++ b/remoting/host/cast_extension_session.cc
@@ -71,16 +71,16 @@ class CastSetSessionDescriptionObserver
static CastSetSessionDescriptionObserver* Create() {
return new rtc::RefCountedObject<CastSetSessionDescriptionObserver>();
}
- virtual void OnSuccess() override {
+ void OnSuccess() override {
VLOG(1) << "Setting session description succeeded.";
}
- virtual void OnFailure(const std::string& error) override {
+ void OnFailure(const std::string& error) override {
LOG(ERROR) << "Setting session description failed: " << error;
}
protected:
CastSetSessionDescriptionObserver() {}
- virtual ~CastSetSessionDescriptionObserver() {}
+ ~CastSetSessionDescriptionObserver() override {}
DISALLOW_COPY_AND_ASSIGN(CastSetSessionDescriptionObserver);
};
@@ -95,7 +95,7 @@ class CastCreateSessionDescriptionObserver
return new rtc::RefCountedObject<CastCreateSessionDescriptionObserver>(
session);
}
- virtual void OnSuccess(webrtc::SessionDescriptionInterface* desc) override {
+ void OnSuccess(webrtc::SessionDescriptionInterface* desc) override {
if (cast_extension_session_ == NULL) {
LOG(ERROR)
<< "No CastExtensionSession. Creating session description succeeded.";
@@ -103,7 +103,7 @@ class CastCreateSessionDescriptionObserver
}
cast_extension_session_->OnCreateSessionDescription(desc);
}
- virtual void OnFailure(const std::string& error) override {
+ void OnFailure(const std::string& error) override {
if (cast_extension_session_ == NULL) {
LOG(ERROR)
<< "No CastExtensionSession. Creating session description failed.";
@@ -118,7 +118,7 @@ class CastCreateSessionDescriptionObserver
protected:
explicit CastCreateSessionDescriptionObserver(CastExtensionSession* session)
: cast_extension_session_(session) {}
- virtual ~CastCreateSessionDescriptionObserver() {}
+ ~CastCreateSessionDescriptionObserver() override {}
private:
CastExtensionSession* cast_extension_session_;
@@ -134,8 +134,7 @@ class CastStatsObserver : public webrtc::StatsObserver {
return new rtc::RefCountedObject<CastStatsObserver>();
}
- virtual void OnComplete(
- const std::vector<webrtc::StatsReport>& reports) override {
+ void OnComplete(const std::vector<webrtc::StatsReport>& reports) override {
typedef webrtc::StatsReport::Values::iterator ValuesIterator;
VLOG(1) << "Received " << reports.size() << " new StatsReports.";
@@ -153,7 +152,7 @@ class CastStatsObserver : public webrtc::StatsObserver {
protected:
CastStatsObserver() {}
- virtual ~CastStatsObserver() {}
+ ~CastStatsObserver() override {}
DISALLOW_COPY_AND_ASSIGN(CastStatsObserver);
};
« no previous file with comments | « remoting/host/cast_extension_session.h ('k') | remoting/host/cast_video_capturer_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698