Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
asanka
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/download/ BUG=417463 TBR=asanka@chromium.org Committed: https://crrev.com/0c8ba27e0a4f11bd50112c1a5d77b68346bbf150 Cr-Commit-Position: refs/heads/master@{#300467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -259 lines) Patch
M chrome/browser/download/all_download_item_notifier.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 4 chunks +36 lines, -43 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 12 chunks +25 lines, -36 lines 0 comments Download
M chrome/browser/download/download_completion_blocker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_danger_prompt.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/download/download_dir_policy_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file_picker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_history.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/download/download_history.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_permission_request.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/download/download_resource_throttle.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_service_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_shelf_context_menu.h View 3 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/download/download_status_updater.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_status_updater_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_target_determiner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_test_file_activity_observer.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/download/download_ui_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_ui_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 11 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/download/test_download_shelf.h View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:30:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665253002/1
6 years, 2 months ago (2014-10-21 09:31:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27517)
6 years, 2 months ago (2014-10-21 10:44:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665253002/1
6 years, 2 months ago (2014-10-21 10:48:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 12:01:10 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c8ba27e0a4f11bd50112c1a5d77b68346bbf150 Cr-Commit-Position: refs/heads/master@{#300467}
6 years, 2 months ago (2014-10-21 12:01:51 UTC) #9
asanka
6 years, 2 months ago (2014-10-21 14:59:16 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698